Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 308323002: Oilpan: Clear unused slots in Deque so they are not found in conservative GCs (Closed)

Created:
6 years, 6 months ago by Erik Corry
Modified:
6 years, 6 months ago
Reviewers:
mikhail.pozdnyakov, Mads Ager (chromium), Mikhail
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, abarth-chromium
Visibility:
Public.

Description

Oilpan: Clear unused slots in Deque so they are not found in conservative GCs If we find a direct pointer to the backing store of the deque (this will normally be an iterator) we have to trace the backing without knowing how much of it is in use (that information is in the Deque itself, not the backing store). This means we have to ensure that unused areas of the backing store are zeroed out. R=ager@chromium.org, mikhail.pozdnyakov@untel.com BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M Source/wtf/Deque.h View 4 chunks +9 lines, -2 lines 0 comments Download
M Source/wtf/Vector.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Erik Corry
6 years, 6 months ago (2014-06-02 09:43:50 UTC) #1
Mikhail
lgtm
6 years, 6 months ago (2014-06-02 09:52:22 UTC) #2
Mads Ager (chromium)
lgtm2
6 years, 6 months ago (2014-06-02 10:05:31 UTC) #3
Erik Corry
The CQ bit was checked by erik.corry@gmail.com
6 years, 6 months ago (2014-06-02 10:25:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erik.corry@gmail.com/308323002/1
6 years, 6 months ago (2014-06-02 10:26:11 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-02 11:42:24 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 12:05:19 UTC) #7
Message was sent while issue was closed.
Change committed as 175277

Powered by Google App Engine
This is Rietveld 408576698