Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 308313004: Extract shouldPropagateKey method from ContentViewClient. (Closed)

Created:
6 years, 6 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, benm (inactive)
Visibility:
Public.

Description

Extract shouldPropagateKey method from ContentViewClient. This is to share the same code path with WebView, which currently has its own copy/paste version of the code, and keep its behavior in sync with it. This change is a pure refactoring and should have no effect on Chrome. BUG=b/14438911 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274300

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -21 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 2 chunks +29 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Primiano Tucci (use gerrit)
6 years, 6 months ago (2014-06-02 14:01:25 UTC) #1
mkosiba (inactive)
lgtm
6 years, 6 months ago (2014-06-02 14:03:56 UTC) #2
bulach
lgtm, thanks!
6 years, 6 months ago (2014-06-02 14:31:24 UTC) #3
Primiano Tucci (use gerrit)
Looks Good To Martin, Looks Good To Marcus, seems ready to go :) Thanks for ...
6 years, 6 months ago (2014-06-02 14:36:37 UTC) #4
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 6 months ago (2014-06-02 14:36:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/308313004/1
6 years, 6 months ago (2014-06-02 14:37:51 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 19:17:49 UTC) #7
Message was sent while issue was closed.
Change committed as 274300

Powered by Google App Engine
This is Rietveld 408576698