Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1645)

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

Issue 308273002: Made the bookmarks extension APIs aware of managed bookmarks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc
diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc
index 0d5d25eb98b5c2fd8048ba6912c5580ed2fc0770..df978ec552a3ef99302c33290ee71b6a475722d8 100644
--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc
+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc
@@ -7,12 +7,14 @@
#include "base/command_line.h"
#include "base/prefs/pref_service.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/values.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/common/pref_names.h"
#include "components/bookmarks/browser/bookmark_model.h"
+#include "components/bookmarks/common/bookmark_pref_names.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "components/user_prefs/user_prefs.h"
@@ -23,6 +25,23 @@
#define MAYBE_BookmarkManager BookmarkManager
#endif
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_BookmarkManager) {
+ // Add managed bookmarks.
+ Profile* profile = browser()->profile();
+ BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile);
+ test::WaitForBookmarkModelToLoad(model);
+
+ base::ListValue list;
+ base::DictionaryValue* node = new base::DictionaryValue();
+ node->SetString("name", "Managed Bookmark");
+ node->SetString("url", "http://www.chromium.org");
+ list.Append(node);
+ node = new base::DictionaryValue();
+ node->SetString("name", "Managed Folder");
+ node->Set("children", new base::ListValue());
+ list.Append(node);
+ profile->GetPrefs()->Set(prefs::kManagedBookmarks, list);
+ ASSERT_EQ(2, model->managed_node()->child_count());
+
ASSERT_TRUE(RunComponentExtensionTest("bookmark_manager/standard"))
<< message_;
}

Powered by Google App Engine
This is Rietveld 408576698