Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4513)

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

Issue 308273002: Made the bookmarks extension APIs aware of managed bookmarks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
diff --git a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
index 505fd0a5d65bf4b4aee80b21255c86aa5ae3dfb7..6c9f98f914837558d4a1c5df05b083491eb47970 100644
--- a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
+++ b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
@@ -162,6 +162,10 @@ const BookmarkNode* BookmarksFunction::CreateBookmarkNode(
error_ = keys::kModifySpecialError;
return NULL;
}
+ if (model->IsManaged(parent)) {
+ error_ = keys::kModifyManagedError;
+ return NULL;
+ }
int index;
if (!details.index.get()) { // Optional (defaults to end).
@@ -639,6 +643,10 @@ bool BookmarksMoveFunction::RunOnReady() {
error_ = keys::kModifySpecialError;
return false;
}
+ if (model->IsManaged(parent) || model->IsManaged(node)) {
+ error_ = keys::kModifyManagedError;
+ return false;
+ }
int index;
if (params->destination.index.get()) { // Optional (defaults to end).
@@ -703,6 +711,11 @@ bool BookmarksUpdateFunction::RunOnReady() {
error_ = keys::kModifySpecialError;
return false;
}
+ if (model->IsManaged(node)) {
+ error_ = keys::kModifyManagedError;
+ return false;
+ }
+
if (has_title)
model->SetTitle(node, title);
if (!url.is_empty())
@@ -896,7 +909,7 @@ void BookmarksMoveFunction::GetQuotaLimitHeuristics(
void BookmarksUpdateFunction::GetQuotaLimitHeuristics(
QuotaLimitHeuristics* heuristics) const {
BookmarksQuotaLimitFactory::Build<BookmarksUpdateFunction>(heuristics);
-};
+}
void BookmarksCreateFunction::GetQuotaLimitHeuristics(
QuotaLimitHeuristics* heuristics) const {

Powered by Google App Engine
This is Rietveld 408576698