Issue 308223002: Accept spaces before/after testharness.js output and CONSOLE output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308223002: Accept spaces before/after testharness.js output and CONSOLE output. (Closed)

Created:
6 years, 6 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 6 months ago

Reviewers:
Dirk Pranke

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@navigator_crash_test

Visibility:
Public.

More Reviews

Description

Accept spaces before/after testharness.js output and CONSOLE output. Some tests trigger CONSOLE output of various kind (LOG, ERROR, etc.) for legitimate reasons so we shouldn't break those tests. Furthermore, we are a little too pedantic with regards to whitespaces around testharness output. Given how we get that output (ie. using element.innerText), we should be less restrictive. BUG=379442 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175272

Patch Set 1 #

Patch Set 2 : accept all CONSOLE output #

Patch Set 3 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -3 lines)			Patch
	M	Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download
	M	Tools/Scripts/webkitpy/layout_tests/port/test.py	View	1 2	2 chunks	+13 lines, -1 line	0 comments	Download