Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3495)

Unified Diff: cc/test/mock_occlusion_tracker.h

Issue 308193003: Removed QuadSink and MockQuadCuller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@plumLayerImpl
Patch Set: rm unused line Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/mock_occlusion_tracker.h
diff --git a/cc/test/mock_occlusion_tracker.h b/cc/test/mock_occlusion_tracker.h
index d46f5b7923af141cec0e61b8a269387273348180..4624a5627e8e38b20e70300cfb6c42417e1c6d00 100644
--- a/cc/test/mock_occlusion_tracker.h
+++ b/cc/test/mock_occlusion_tracker.h
@@ -10,7 +10,7 @@
namespace cc {
template <typename LayerType>
-class MockOcclusionTracker : public OcclusionTracker<LayerType> {
+class CC_EXPORT MockOcclusionTracker : public OcclusionTracker<LayerType> {
// This class is used for testing only. It fakes just enough information to
// calculate unoccluded content rect and unoccluded contributing surface
// content rect. It calls the helper function of occlusion tracker to avoid
@@ -42,7 +42,7 @@ class MockOcclusionTracker : public OcclusionTracker<LayerType> {
.occlusion_from_inside_target = occluded;
}
- gfx::Rect UnoccludedContentRect(
+ virtual gfx::Rect UnoccludedContentRect(
enne (OOO) 2014/05/30 21:37:43 style nit: don't inline virtuals Also, isn't this
weiliangc 2014/05/30 21:46:07 In unittest the OcclusionTracker and LayerImpls ar
enne (OOO) 2014/05/30 22:11:10 Hmm, ok. I'm always saddened by virtual-for-testi
const LayerType* render_target,
const gfx::Rect& content_rect,
const gfx::Transform& draw_transform) const OVERRIDE {
@@ -50,13 +50,16 @@ class MockOcclusionTracker : public OcclusionTracker<LayerType> {
render_target, content_rect, draw_transform);
}
- gfx::Rect UnoccludedContributingSurfaceContentRect(
+ virtual gfx::Rect UnoccludedContributingSurfaceContentRect(
const LayerType* layer,
const gfx::Rect& content_rect,
const gfx::Transform& draw_transform) const OVERRIDE {
return this->UnoccludedContributingSurfaceContentRectHelper(
layer, content_rect, draw_transform);
}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(MockOcclusionTracker);
};
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698