Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 308193002: Simplify AcceleratorDelegate interface (Closed)

Created:
6 years, 6 months ago by oshima
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Simplify AcceleratorDelegate interface BUG=None TEST=no functional change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274035

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : fixed condition #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -39 lines) Patch
M ash/accelerators/accelerator_delegate.h View 1 chunk +10 lines, -5 lines 0 comments Download
M ash/accelerators/accelerator_delegate.cc View 1 2 3 chunks +21 lines, -6 lines 2 comments Download
M ui/wm/core/accelerator_delegate.h View 1 1 chunk +9 lines, -10 lines 0 comments Download
M ui/wm/core/accelerator_filter.cc View 1 2 2 chunks +7 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
oshima
https://codereview.chromium.org/308193002/diff/60001/ash/accelerators/accelerator_delegate.h File ash/accelerators/accelerator_delegate.h (right): https://codereview.chromium.org/308193002/diff/60001/ash/accelerators/accelerator_delegate.h#newcode22 ash/accelerators/accelerator_delegate.h:22: const ui::Accelerator& accelerator) OVERRIDE; This will be removed in ...
6 years, 6 months ago (2014-05-30 19:53:53 UTC) #1
sky
LGTM https://codereview.chromium.org/308193002/diff/60001/ui/wm/core/accelerator_delegate.h File ui/wm/core/accelerator_delegate.h (right): https://codereview.chromium.org/308193002/diff/60001/ui/wm/core/accelerator_delegate.h#newcode21 ui/wm/core/accelerator_delegate.h:21: SYSTEM_KEYS, KEY_TYPE_SYSTEM https://codereview.chromium.org/308193002/diff/60001/ui/wm/core/accelerator_delegate.h#newcode22 ui/wm/core/accelerator_delegate.h:22: NORMAL_KEYS, KEY_TYPE_NORMAL, or maybe ...
6 years, 6 months ago (2014-05-30 20:27:40 UTC) #2
oshima
On 2014/05/30 20:27:40, sky wrote: > LGTM > > https://codereview.chromium.org/308193002/diff/60001/ui/wm/core/accelerator_delegate.h > File ui/wm/core/accelerator_delegate.h (right): > ...
6 years, 6 months ago (2014-05-30 20:34:16 UTC) #3
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-05-30 20:34:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/308193002/80001
6 years, 6 months ago (2014-05-30 20:36:24 UTC) #5
oshima
The CQ bit was unchecked by oshima@chromium.org
6 years, 6 months ago (2014-05-30 23:09:25 UTC) #6
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-05-30 23:41:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/308193002/140001
6 years, 6 months ago (2014-05-30 23:47:50 UTC) #8
oshima
FYI: https://codereview.chromium.org/308193002/diff/140001/ash/accelerators/accelerator_delegate.cc File ash/accelerators/accelerator_delegate.cc (right): https://codereview.chromium.org/308193002/diff/140001/ash/accelerators/accelerator_delegate.cc#newcode43 ash/accelerators/accelerator_delegate.cc:43: if (!ShouldProcessAcceleratorNow(key_event, accelerator)) FYI: The rest of code ...
6 years, 6 months ago (2014-05-30 23:50:28 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 05:04:53 UTC) #10
Message was sent while issue was closed. 
Change committed as 274035

Powered by Google App Engine
This is Rietveld 408576698