Remove extra newline in log lines from plugin.

Remove extra newline in log lines from plugin.

Currently log lines from the plugin get 2 newlines, which wastes space in
the console output. This strips off the extra newline.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274312

[Jamie, 2014-05-30 22:13:32]

lgtm

[Jamie, 2014-05-30 22:14:42]

Is it possible to remove newlines at source, rather than just before printing?

[garykac, 2014-05-31 01:12:25]

On 2014/05/30 22:14:42, Jamie wrote:
> Is it possible to remove newlines at source, rather than just before printing?

Sure, we could do it in ChromotingInstance::ProcessLogToUI:
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/client/pl...

But since it's a const std::string, we'd have to make a copy, so it seems easier
to just trim it in the JS.

[Jamie, 2014-05-31 01:14:19]

On 2014/05/31 01:12:25, garykac wrote:
> On 2014/05/30 22:14:42, Jamie wrote:
> > Is it possible to remove newlines at source, rather than just before
printing?
> 
> Sure, we could do it in ChromotingInstance::ProcessLogToUI:
>
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/client/pl...
> 
> But since it's a const std::string, we'd have to make a copy, so it seems
easier
> to just trim it in the JS.

How about in whatever calls ProcessLogToUI? Those newlines must be coming from
somewhere, and it would be cleaner to remove them at source.

[garykac, 2014-05-31 20:43:31]

On 2014/05/31 01:14:19, Jamie wrote:
> On 2014/05/31 01:12:25, garykac wrote:
> > On 2014/05/30 22:14:42, Jamie wrote:
> > > Is it possible to remove newlines at source, rather than just before
> printing?
> > 
> > Sure, we could do it in ChromotingInstance::ProcessLogToUI:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/client/pl...
> > 
> > But since it's a const std::string, we'd have to make a copy, so it seems
> easier
> > to just trim it in the JS.
> 
> How about in whatever calls ProcessLogToUI? Those newlines must be coming from
> somewhere, and it would be cleaner to remove them at source.

Not really. This is a log message handler that is registered to capture LOG/VLOG
lines.

The original log message doesn't have a newline, and by the time it gets to the
handler it already has a newline.

[Jamie, 2014-06-01 03:24:26]

On 2014/05/31 20:43:31, garykac wrote:
> On 2014/05/31 01:14:19, Jamie wrote:
> > On 2014/05/31 01:12:25, garykac wrote:
> > > On 2014/05/30 22:14:42, Jamie wrote:
> > > > Is it possible to remove newlines at source, rather than just before
> > printing?
> > > 
> > > Sure, we could do it in ChromotingInstance::ProcessLogToUI:
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/client/pl...
> > > 
> > > But since it's a const std::string, we'd have to make a copy, so it seems
> > easier
> > > to just trim it in the JS.
> > 
> > How about in whatever calls ProcessLogToUI? Those newlines must be coming
from
> > somewhere, and it would be cleaner to remove them at source.
> 
> Not really. This is a log message handler that is registered to capture
LOG/VLOG
> lines.
> 
> The original log message doesn't have a newline, and by the time it gets to
the
> handler it already has a newline.

Fair enough. LGTM again.

[garykac, 2014-06-02 16:40:09]

The CQ bit was checked by garykac@chromium.org

[commit-bot: I haz the power, 2014-06-02 16:40:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/garykac@chromium.org/308183004/1

[commit-bot: I haz the power, 2014-06-02 19:44:54]

Change committed as 274312