Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 308173002: Fix race and remove unused features in cryptotoken extension (Closed)

Created:
6 years, 6 months ago by Arnar Birgisson
Modified:
6 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix race and remove unused features in cryptotoken extension BUG=378965 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274016

Patch Set 1 #

Patch Set 2 : Changes to background.js #

Total comments: 1

Patch Set 3 : Fix type annotation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -219 lines) Patch
M chrome/browser/resources/cryptotoken/background.js View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/cryptotoken/enroller.js View 3 chunks +5 lines, -19 lines 0 comments Download
M chrome/browser/resources/cryptotoken/gnubbies.js View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/cryptotoken/gnubby.js View 1 2 5 chunks +33 lines, -20 lines 0 comments Download
M chrome/browser/resources/cryptotoken/gnubby-u2f.js View 4 chunks +61 lines, -29 lines 0 comments Download
M chrome/browser/resources/cryptotoken/llgnubby.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/cryptotoken/llhidgnubby.js View 4 chunks +5 lines, -20 lines 0 comments Download
M chrome/browser/resources/cryptotoken/llusbgnubby.js View 3 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/resources/cryptotoken/signer.js View 14 chunks +24 lines, -96 lines 0 comments Download
M chrome/browser/resources/cryptotoken/signhelper.js View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/resources/cryptotoken/usbsignhelper.js View 3 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Arnar Birgisson
Xiyuan, Juan, This CL brings the component extension up to date, fixing the race issues ...
6 years, 6 months ago (2014-05-30 18:47:19 UTC) #1
juanlang (chromium.org)
lgtm Looks fine, modulo one error that appears to have crept in upstream. https://codereview.chromium.org/308173002/diff/20001/chrome/browser/resources/cryptotoken/gnubby.js File ...
6 years, 6 months ago (2014-05-30 20:38:07 UTC) #2
xiyuan
stampy LGTM
6 years, 6 months ago (2014-05-30 20:42:14 UTC) #3
Arnar Birgisson
The CQ bit was checked by arnarb@chromium.org
6 years, 6 months ago (2014-05-30 21:58:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/308173002/40001
6 years, 6 months ago (2014-05-30 22:01:32 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium ...
6 years, 6 months ago (2014-05-31 03:01:53 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 04:28:04 UTC) #7
Message was sent while issue was closed.
Change committed as 274016

Powered by Google App Engine
This is Rietveld 408576698