Issue 308163002: NaCl: Remove nacl_thread.h from NaCl SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308163002: NaCl: Remove nacl_thread.h from NaCl SDK (Closed)

Created:
6 years, 6 months ago by Mark Seaborn

Modified:
6 years, 6 months ago

Reviewers:
binji

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Remove nacl_thread.h from NaCl SDK nacl_thread.h only defines nacl_tls_get() and nacl_tls_init(), which are not generally useful for application code. They are only used internally within libc/libpthread. This is part of general cleanup to reduce Chromium-side dependencies on NaCl headers that are not in public directories (src/include/nacl and src/public). BUG=https://code.google.com/p/nativeclient/issues/detail?id=2832 TEST=NaCl SDK bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274027

Patch Set 1 #

Patch Set 2 : Fix build #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	native_client_sdk/src/build_tools/build_sdk.py	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	native_client_sdk/src/build_tools/sdk_files.list	View	1	4 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/308163002/20001

6 years, 6 months ago (2014-05-30 22:55:57 UTC) #4

Message was sent while issue was closed.

Change committed as 274027

Expand Messages | Collapse Messages