Issue 308143008: Change #def to be opt-out

Issue 308143008: Change #def to be opt-out (Closed)

Created:
6 years, 6 months ago by krajcevski

Modified:
6 years, 6 months ago

Reviewers:
jvanverth1, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Change #def to be opt-out Committed: https://skia.googlesource.com/skia/+/8c111f783f40470e697310244426362132979ad9

Patch Set 2 : Remove old define #

Total comments: 2

Patch Set 3 : Add comma #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
M	gyp/common_conditions.gypi	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	gyp/skia_for_chromium_defines.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/SkGr.cpp	View		4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm modulo ',' https://codereview.chromium.org/308143008/diff/20001/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/308143008/diff/20001/gyp/common_conditions.gypi#newcode7 gyp/common_conditions.gypi:7: 'SK_SUPPORT_OPENCL=<(skia_opencl)', need , !?

6 years, 6 months ago (2014-06-02 19:57:24 UTC) #2

krajcevski

https://codereview.chromium.org/308143008/diff/20001/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/308143008/diff/20001/gyp/common_conditions.gypi#newcode7 gyp/common_conditions.gypi:7: 'SK_SUPPORT_OPENCL=<(skia_opencl)', On 2014/06/02 19:57:24, robertphillips wrote: > need , ...

6 years, 6 months ago (2014-06-02 20:19:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/308143008/40001

6 years, 6 months ago (2014-06-02 20:39:13 UTC) #5

commit-bot: I haz the power

6 years, 6 months ago (2014-06-02 20:51:39 UTC) #6

Message was sent while issue was closed.

Change committed as 8c111f783f40470e697310244426362132979ad9

Expand Messages | Collapse Messages