Source/core/css/resolver/FontBuilder.h - Issue 308123010: Trigger computation of font size when crossing foreignObject boundary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/FontBuilder.h

Issue 308123010: Trigger computation of font size when crossing foreignObject boundary (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Simplify patch using StateResolverState mechanisms Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/svg/custom/foreignObject-font-size-on-zoom-expected.html ('k') | Source/core/css/resolver/FontBuilder.cpp » ('j') | Source/core/css/resolver/StyleResolver.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/resolver/FontBuilder.h

diff --git a/Source/core/css/resolver/FontBuilder.h b/Source/core/css/resolver/FontBuilder.h

index 3a24f72120f95d9f5e412f47c94745a22d8de02f..fdc8b5c0052e7d3ce9525f0aefc3a682ca341517 100644

--- a/Source/core/css/resolver/FontBuilder.h

+++ b/Source/core/css/resolver/FontBuilder.h

@@ -43,7 +43,7 @@ public:

FontBuilder();

// FIXME: The name is probably wrong, but matches StyleResolverState callsite for consistency.

- void initForStyleResolve(const Document&, RenderStyle*, bool useSVGZoomRules);

+ void initForStyleResolve(const Document&, RenderStyle*);

void setInitial(float effectiveZoom);

@@ -112,7 +112,6 @@ private:

float getComputedSizeFromSpecifiedSize(FontDescription&, float effectiveZoom, float specifiedSize);

const Document* m_document;

- bool m_useSVGZoomRules;

bool m_fontSizehasViewportUnits;

// FIXME: This member is here on a short-term lease. The plan is to remove

// any notion of RenderStyle from here, allowing FontBuilder to build Font objects