Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: Source/core/css/resolver/FontBuilder.h

Issue 308123010: Trigger computation of font size when crossing foreignObject boundary (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove use of useSVGZoomRules in FontBuilder and add a forced mode for when crossing the foreignObj… Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/FontBuilder.h
diff --git a/Source/core/css/resolver/FontBuilder.h b/Source/core/css/resolver/FontBuilder.h
index 3a24f72120f95d9f5e412f47c94745a22d8de02f..8367a1df36ede226769c0c86f01264e6fffc8744 100644
--- a/Source/core/css/resolver/FontBuilder.h
+++ b/Source/core/css/resolver/FontBuilder.h
@@ -42,8 +42,13 @@ class FontBuilder {
public:
FontBuilder();
+ enum FontBuilderOperation {
+ OnlyBuildFontOnChange,
+ AlwaysBuildFont,
+ };
+
// FIXME: The name is probably wrong, but matches StyleResolverState callsite for consistency.
- void initForStyleResolve(const Document&, RenderStyle*, bool useSVGZoomRules);
+ void initForStyleResolve(const Document&, RenderStyle*, FontBuilderOperation = OnlyBuildFontOnChange);
pdr. 2014/06/03 16:40:46 Could you add a comment here explaining why one wo
void setInitial(float effectiveZoom);
@@ -112,7 +117,6 @@ private:
float getComputedSizeFromSpecifiedSize(FontDescription&, float effectiveZoom, float specifiedSize);
const Document* m_document;
- bool m_useSVGZoomRules;
bool m_fontSizehasViewportUnits;
// FIXME: This member is here on a short-term lease. The plan is to remove
// any notion of RenderStyle from here, allowing FontBuilder to build Font objects

Powered by Google App Engine
This is Rietveld 408576698