Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 308123008: DevTools: added support for image url & node in tracing-based timeline (Closed)

Created:
6 years, 6 months ago by caseq
Modified:
6 years, 6 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-rendering, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, zoltan1, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, pdr., rune+blink
Visibility:
Public.

Description

DevTools: added support for image url & node in tracing-based timeline - add trace event for RenderImage::paintIntoRect; - fix name of decode & resize image events for tracing vs. old timeline; - add processing of decode/resize/paint/imageref events to TimelineTraceEventBindings; - generalize handling of additional event properties when building details, so that we avoid extra switches over event type by extracting properties relevant for details into TraceEvent properties; - temporary workaround for crash on record stop in tests by cloning an AtomicString (see crbug.com/375242 for more details). BUG=361045, 375242 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175284

Patch Set 1 #

Total comments: 4

Patch Set 2 : skip check for presence of endData in Layout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -158 lines) Patch
A LayoutTests/inspector/timeline/tracing/decode-resize.html View 1 chunk +87 lines, -0 lines 0 comments Download
A LayoutTests/inspector/timeline/tracing/decode-resize-expected.txt View 1 chunk +25 lines, -0 lines 0 comments Download
M LayoutTests/inspector/tracing-test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.h View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 3 chunks +13 lines, -1 line 0 comments Download
M Source/core/rendering/RenderImage.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineTraceEventBindings.js View 1 6 chunks +58 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 8 chunks +150 lines, -153 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingModel.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
caseq
6 years, 6 months ago (2014-06-02 08:57:58 UTC) #1
yurys
lgtm https://codereview.chromium.org/308123008/diff/1/Source/devtools/front_end/timeline/TimelineTraceEventBindings.js File Source/devtools/front_end/timeline/TimelineTraceEventBindings.js (right): https://codereview.chromium.org/308123008/diff/1/Source/devtools/front_end/timeline/TimelineTraceEventBindings.js#newcode212 Source/devtools/front_end/timeline/TimelineTraceEventBindings.js:212: if (event.args["endData"]) endData always exists for Layout event, ...
6 years, 6 months ago (2014-06-02 11:22:23 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-02 11:57:06 UTC) #3
caseq
The CQ bit was unchecked by caseq@chromium.org
6 years, 6 months ago (2014-06-02 11:57:08 UTC) #4
caseq
https://codereview.chromium.org/308123008/diff/1/Source/devtools/front_end/timeline/TimelineTraceEventBindings.js File Source/devtools/front_end/timeline/TimelineTraceEventBindings.js (right): https://codereview.chromium.org/308123008/diff/1/Source/devtools/front_end/timeline/TimelineTraceEventBindings.js#newcode212 Source/devtools/front_end/timeline/TimelineTraceEventBindings.js:212: if (event.args["endData"]) On 2014/06/02 11:22:24, yurys wrote: > endData ...
6 years, 6 months ago (2014-06-02 11:57:19 UTC) #5
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-02 11:57:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/308123008/20001
6 years, 6 months ago (2014-06-02 11:57:38 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 14:20:03 UTC) #8
Message was sent while issue was closed.
Change committed as 175284

Powered by Google App Engine
This is Rietveld 408576698