Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Issue 308123006: Add GN build file for src/sdch (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix include path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -71 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
A + sdch/BUILD.gn View 1 5 chunks +24 lines, -8 lines 0 comments Download
D tools/gn/secondary/sdch/BUILD.gn View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 6 months ago (2014-06-01 00:42:38 UTC) #1
Mark Mentovai
LGTM
6 years, 6 months ago (2014-06-01 04:03:31 UTC) #2
brettw
6 years, 6 months ago (2014-06-02 17:40:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r274271 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698