Issue 3081013: Fix for pdf plugin not loaded in the linux sandbox. Also, not showing...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3081013: Fix for pdf plugin not loaded in the linux sandbox. Also, not showing... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by gene

Modified:
3 years, 11 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix for pdf plugin not loaded in the linux sandbox. BUG=none TEST=Run linux Chrome with sandbox and verify internal PDF viewer displaying PDFs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54986

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/common/pepper_plugin_registry.cc	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download

Trybot results: linux mac win

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

4 years, 10 months ago (2010-08-04 22:29:15 UTC) #2

LGTM with comment enhancement.

http://codereview.chromium.org/3081013/diff/5001/6001
File chrome/common/pepper_plugin_registry.cc (right):

http://codereview.chromium.org/3081013/diff/5001/6001#newcode98
chrome/common/pepper_plugin_registry.cc:98: // If plugin is missing, we'll
display error  message.
can you clarify "we'll display error message" to "it will later fail to load the
library and the missing plugin message will be displayed."

Expand Messages | Collapse Messages