Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 308083011: Add support for painting halos on Views Labels. (Closed)

Created:
6 years, 6 months ago by msw
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, Elliot Glaysher
Visibility:
Public.

Description

Add support for painting halos on Views Labels. Needed for converting some TextButtons to LabelButtons. (eg. new avatar button, bookmark buttons on drag) BUG=155363 TEST=Label example shows a halo'ed label. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274848

Patch Set 1 #

Patch Set 2 : Add example, sync and rebase. #

Patch Set 3 : Draw halos over shadows; refine function order and example. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M ui/views/controls/label.h View 1 2 3 chunks +9 lines, -2 lines 0 comments Download
M ui/views/controls/label.cc View 1 2 2 chunks +11 lines, -4 lines 0 comments Download
M ui/views/examples/label_example.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
msw
Hey Scott, please take a look; thanks! FYI, Elliot.
6 years, 6 months ago (2014-06-03 20:44:35 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-03 22:02:14 UTC) #2
msw
The CQ bit was checked by msw@chromium.org
6 years, 6 months ago (2014-06-03 22:05:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/308083011/40001
6 years, 6 months ago (2014-06-03 22:07:19 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 23:58:16 UTC) #5
msw
The CQ bit was checked by msw@chromium.org
6 years, 6 months ago (2014-06-04 16:46:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/308083011/40001
6 years, 6 months ago (2014-06-04 16:48:16 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 16:50:52 UTC) #8
Message was sent while issue was closed.
Change committed as 274848

Powered by Google App Engine
This is Rietveld 408576698