Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 308083006: Don't push eax/rax before calling Runtime_Abort (Closed)

Created:
6 years, 6 months ago by Toon Verwaest
Modified:
6 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Don't push eax/rax before calling Runtime_Abort Additionally delete the unused Throw(BailoutReason) BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -254 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +0 lines, -35 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M src/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 6 months ago (2014-05-30 14:21:40 UTC) #1
Jakob Kummerow
LGTM. Delete ALL the code!
6 years, 6 months ago (2014-05-30 14:26:48 UTC) #2
Toon Verwaest
6 years, 6 months ago (2014-05-30 14:27:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21582 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698