Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 308083005: Improving layout and a11y for HID detection OOBE screen. (Closed)

Created:
6 years, 6 months ago by merkulova
Modified:
6 years, 6 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Improving layout and a11y for HID detection OOBE screen. BUG=379124 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274733

Patch Set 1 #

Patch Set 2 : Rtl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.css View 1 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.html View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
merkulova
6 years, 6 months ago (2014-05-30 12:37:05 UTC) #1
merkulova
ping)
6 years, 6 months ago (2014-06-03 07:09:47 UTC) #2
dzhioev (left Google)
On 2014/06/03 07:09:47, merkulova wrote: > ping) LGTM
6 years, 6 months ago (2014-06-03 13:48:57 UTC) #3
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 6 months ago (2014-06-03 13:56:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/308083005/20001
6 years, 6 months ago (2014-06-03 13:56:58 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 19:57:15 UTC) #6
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 6 months ago (2014-06-04 05:55:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/308083005/20001
6 years, 6 months ago (2014-06-04 05:57:09 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 08:59:09 UTC) #9
Message was sent while issue was closed.
Change committed as 274733

Powered by Google App Engine
This is Rietveld 408576698