Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6830)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 308083004: Tentatively enable StartupBrowserCreatorFirstRunTest.* on official Mac builder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
index 4e13e8df0ee84be973660cfa516515ae1bca6d28..ec9be7602da0c838ea98d77d85521467b19df4cd 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
@@ -1077,14 +1077,7 @@ void StartupBrowserCreatorFirstRunTest::SetUpInProcessBrowserTestFixture() {
#endif // defined(ENABLE_CONFIGURATION_POLICY)
}
-#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
-// http://crbug.com/314819
-#define MAYBE_SyncPromoForbidden DISABLED_SyncPromoForbidden
-#else
-#define MAYBE_SyncPromoForbidden SyncPromoForbidden
-#endif
-IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
- MAYBE_SyncPromoForbidden) {
+IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, SyncPromoForbidden) {
// Consistently enable the welcome page on all platforms.
first_run::SetShouldShowWelcomePage();
@@ -1118,14 +1111,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
tab_strip->GetWebContentsAt(1)->GetURL());
}
-#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
-// http://crbug.com/314819
-#define MAYBE_SyncPromoAllowed DISABLED_SyncPromoAllowed
-#else
-#define MAYBE_SyncPromoAllowed SyncPromoAllowed
-#endif
-IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
- MAYBE_SyncPromoAllowed) {
+IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, SyncPromoAllowed) {
// Consistently enable the welcome page on all platforms.
first_run::SetShouldShowWelcomePage();
@@ -1159,14 +1145,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
tab_strip->GetWebContentsAt(1)->GetURL());
}
-#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
-// http://crbug.com/314819
-#define MAYBE_FirstRunTabsPromoAllowed DISABLED_FirstRunTabsPromoAllowed
-#else
-#define MAYBE_FirstRunTabsPromoAllowed FirstRunTabsPromoAllowed
-#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
- MAYBE_FirstRunTabsPromoAllowed) {
+ FirstRunTabsPromoAllowed) {
// Simulate the following master_preferences:
// {
// "first_run_tabs" : [
@@ -1201,15 +1181,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName());
}
-#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
-// http://crbug.com/314819
-#define MAYBE_FirstRunTabsContainSyncPromo \
- DISABLED_FirstRunTabsContainSyncPromo
-#else
-#define MAYBE_FirstRunTabsContainSyncPromo FirstRunTabsContainSyncPromo
-#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
- MAYBE_FirstRunTabsContainSyncPromo) {
+ FirstRunTabsContainSyncPromo) {
// Simulate the following master_preferences:
// {
// "first_run_tabs" : [
@@ -1249,16 +1222,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
tab_strip->GetWebContentsAt(1)->GetURL());
}
-#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
-// http://crbug.com/314819
-#define MAYBE_FirstRunTabsContainNTPSyncPromoAllowed \
- DISABLED_FirstRunTabsContainNTPSyncPromoAllowed
-#else
-#define MAYBE_FirstRunTabsContainNTPSyncPromoAllowed \
- FirstRunTabsContainNTPSyncPromoAllowed
-#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
- MAYBE_FirstRunTabsContainNTPSyncPromoAllowed) {
+ FirstRunTabsContainNTPSyncPromoAllowed) {
// Simulate the following master_preferences:
// {
// "first_run_tabs" : [
@@ -1296,16 +1261,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName());
}
-#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
-// http://crbug.com/314819
-#define MAYBE_FirstRunTabsContainNTPSyncPromoForbidden \
- DISABLED_FirstRunTabsContainNTPSyncPromoForbidden
-#else
-#define MAYBE_FirstRunTabsContainNTPSyncPromoForbidden \
- FirstRunTabsContainNTPSyncPromoForbidden
-#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
- MAYBE_FirstRunTabsContainNTPSyncPromoForbidden) {
+ FirstRunTabsContainNTPSyncPromoForbidden) {
// Simulate the following master_preferences:
// {
// "first_run_tabs" : [
@@ -1343,15 +1300,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName());
}
-#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
-// http://crbug.com/314819
-#define MAYBE_FirstRunTabsSyncPromoForbidden \
- DISABLED_FirstRunTabsSyncPromoForbidden
-#else
-#define MAYBE_FirstRunTabsSyncPromoForbidden FirstRunTabsSyncPromoForbidden
-#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
- MAYBE_FirstRunTabsSyncPromoForbidden) {
+ FirstRunTabsSyncPromoForbidden) {
// Simulate the following master_preferences:
// {
// "first_run_tabs" : [
@@ -1385,16 +1335,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
}
#if defined(ENABLE_CONFIGURATION_POLICY)
-#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
-// http://crbug.com/314819
-#define MAYBE_RestoreOnStartupURLsPolicySpecified \
- DISABLED_RestoreOnStartupURLsPolicySpecified
-#else
-#define MAYBE_RestoreOnStartupURLsPolicySpecified \
- RestoreOnStartupURLsPolicySpecified
-#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
- MAYBE_RestoreOnStartupURLsPolicySpecified) {
+ RestoreOnStartupURLsPolicySpecified) {
// Simulate the following master_preferences:
// {
// "sync_promo": {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698