Issue 308073011: test_runner: Migrate WebUserMediaClientMock to our Chromium C++ style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308073011: test_runner: Migrate WebUserMediaClientMock to our Chromium C++ style. (Closed)

Created:
6 years, 6 months ago by tfarina

Modified:
6 years, 6 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, jochen (gone - plz use gerrit), darin (slow to review), jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

test_runner: Migrate WebUserMediaClientMock to our Chromium C++ style. Changes: 1) Run clang-format through source and header files. 3) Fix data member variables to use unix_hacker_ style. 4) Rename file name to mock_web_user_media_client. 5) Rename class name to MockWebUserMediaClient. BUG=331299 TEST=content_unittests, content_shell. No functional changes TBR=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274171

Patch Set 1 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+158 lines, -358 lines)			Patch
M	content/content_shell.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	content/shell/renderer/test_runner/WebUserMediaClientMock.h	View	1 chunk	+0 lines, -41 lines	0 comments	Download
D	content/shell/renderer/test_runner/WebUserMediaClientMock.cpp	View	1 chunk	+0 lines, -179 lines	0 comments	Download
A +	content/shell/renderer/test_runner/mock_web_user_media_client.h	View	1 chunk	+21 lines, -21 lines	0 comments	Download
A +	content/shell/renderer/test_runner/mock_web_user_media_client.cc	View	2 chunks	+131 lines, -111 lines	0 comments	Download
M	content/shell/renderer/test_runner/web_test_proxy.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/renderer/test_runner/web_test_proxy.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/308073011/20001

6 years, 6 months ago (2014-06-02 01:04:45 UTC) #3

Message was sent while issue was closed.

lgtm, though I didn't go through it in detail.

Expand Messages | Collapse Messages