Clear environment variables for nacl_helper

components/nacl/zygote/nacl_fork_delegate_linux.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NACL_ZYGOTE_NACL_FORK_DELEGATE_LINUX_H_
 #define COMPONENTS_NACL_ZYGOTE_NACL_FORK_DELEGATE_LINUX_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "content/public/common/zygote_fork_delegate_linux.h"
 
+namespace base {
+struct LaunchOptions;
+}
+
 template <typename>
 class ScopedVector;
 
 namespace nacl {
 
 // Appends any ZygoteForkDelegate instances needed by NaCl to |*delegates|.
 void AddNaClZygoteForkDelegates(
     ScopedVector<content::ZygoteForkDelegate>* delegates);
 
 // The NaClForkDelegate is created during Chrome linux zygote
@@ skipping 12 matching lines @@
                           int* uma_boundary_value) OVERRIDE;
   virtual bool CanHelp(const std::string& process_type, std::string* uma_name,
                           int* uma_sample, int* uma_boundary_value) OVERRIDE;
   virtual pid_t Fork(const std::string& process_type,
                      const std::vector<int>& fds,
                      const std::string& channel_id) OVERRIDE;
   virtual bool GetTerminationStatus(pid_t pid, bool known_dead,
                                     base::TerminationStatus* status,
                                     int* exit_code) OVERRIDE;
 
+  static void AddPassthroughEnvToOptions(base::LaunchOptions& options);

[jln (very slow on Chromium), 2014/06/02 21:31:47]

Style: make this a pointer instead as it is non-const.

Also could you add some basic documentation?

Shouldn't it be private?

[elijahtaylor1, 2014/06/03 20:47:54]

Done.
Added to the declaration of NACL_ENV_PASSTHROUGH
Sure, if you don't mind a friend declaration for testing

+
  private:
   // These values are reported via UMA and hence they become permanent
   // constants.  Old values cannot be reused, only new ones added.
   enum NaClHelperStatus {
     kNaClHelperUnused = 0,
     kNaClHelperMissing = 1,
     kNaClHelperBootstrapMissing = 2,
     kNaClHelperValgrind = 3,
     kNaClHelperLaunchFailed = 4,
     kNaClHelperAckFailed = 5,
     kNaClHelperSuccess = 6,
     kNaClHelperStatusBoundary  // Must be one greater than highest value used.
   };
 
   const bool nonsfi_mode_;
   NaClHelperStatus status_;
   int fd_;
 
   DISALLOW_COPY_AND_ASSIGN(NaClForkDelegate);
 };
 
 }  // namespace nacl
 
 #endif  // COMPONENTS_NACL_ZYGOTE_NACL_FORK_DELEGATE_LINUX_H_