Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: chrome/browser/search_engines/template_url.cc

Issue 308053009: Add contextual search to the template url system (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to comments and make contextual search /search requests accessible from Java. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url.cc
diff --git a/chrome/browser/search_engines/template_url.cc b/chrome/browser/search_engines/template_url.cc
index 96c68ebed9c6d9561e0e23fb7684f2108ae902a6..853be23b551b3bd3b5b332a9f2cbc83b013297ee 100644
--- a/chrome/browser/search_engines/template_url.cc
+++ b/chrome/browser/search_engines/template_url.cc
@@ -103,6 +103,16 @@ const char kGoogleImageURLParameter[] = "google:imageURL";
const char kGoogleImageOriginalWidth[] = "google:imageOriginalWidth";
const char kGoogleImageOriginalHeight[] = "google:imageOriginalHeight";
+// Contextual search parameters.
+const char kGoogleContextualSearchVersion[] = "google:contextualSearchVersion";
+const char kGoogleContextualSearchStart[] = "google:contextualSearchStart";
+const char kGoogleContextualSearchEnd[] = "google:contextualSearchEnd";
+const char kGoogleContextualSearchContent[] = "google:contextualSearchContent";
+const char kGoogleContextualSearchBasePageURL[] =
+ "google:contextualSearchBasePageURL";
+const char kGoogleContextualSearchEncoding[] =
+ "google:contextualSearchEncoding";
+
// Display value for kSearchTermsParameter.
const char kDisplaySearchTerms[] = "%s";
@@ -209,7 +219,8 @@ TemplateURLRef::SearchTermsArgs::SearchTermsArgs(
bookmark_bar_pinned(false),
append_extra_query_params(false),
force_instant_results(false),
- from_app_list(false) {
+ from_app_list(false),
+ contextual_search_params(ContextualSearchParams()){
}
TemplateURLRef::SearchTermsArgs::~SearchTermsArgs() {
@@ -251,24 +262,26 @@ TemplateURLRef::~TemplateURLRef() {
std::string TemplateURLRef::GetURL() const {
switch (type_) {
- case SEARCH: return owner_->url();
- case SUGGEST: return owner_->suggestions_url();
- case INSTANT: return owner_->instant_url();
- case IMAGE: return owner_->image_url();
- case NEW_TAB: return owner_->new_tab_url();
- case INDEXED: return owner_->GetURL(index_in_owner_);
- default: NOTREACHED(); return std::string(); // NOLINT
+ case SEARCH: return owner_->url();
+ case SUGGEST: return owner_->suggestions_url();
+ case INSTANT: return owner_->instant_url();
+ case IMAGE: return owner_->image_url();
+ case NEW_TAB: return owner_->new_tab_url();
+ case CONTEXTUAL_SEARCH: return owner_->contextual_search_url();
+ case INDEXED: return owner_->GetURL(index_in_owner_);
+ default: NOTREACHED(); return std::string(); // NOLINT
}
}
std::string TemplateURLRef::GetPostParamsString() const {
switch (type_) {
case INDEXED:
- case SEARCH: return owner_->search_url_post_params();
- case SUGGEST: return owner_->suggestions_url_post_params();
- case INSTANT: return owner_->instant_url_post_params();
- case NEW_TAB: return std::string();
- case IMAGE: return owner_->image_url_post_params();
+ case SEARCH: return owner_->search_url_post_params();
+ case SUGGEST: return owner_->suggestions_url_post_params();
+ case INSTANT: return owner_->instant_url_post_params();
+ case NEW_TAB: return std::string();
+ case CONTEXTUAL_SEARCH: return std::string();
+ case IMAGE: return owner_->image_url_post_params();
default: NOTREACHED(); return std::string(); // NOLINT
}
}
@@ -592,6 +605,24 @@ bool TemplateURLRef::ParseParameter(size_t start,
replacements->push_back(Replacement(GOOGLE_NTP_IS_THEMED, start));
} else if (parameter == kGoogleOmniboxStartMarginParameter) {
replacements->push_back(Replacement(GOOGLE_OMNIBOX_START_MARGIN, start));
+ } else if (parameter == kGoogleContextualSearchVersion) {
+ replacements->push_back(
+ Replacement(GOOGLE_CONTEXTUAL_SEARCH_VERSION, start));
+ } else if (parameter == kGoogleContextualSearchStart) {
+ replacements->push_back(
+ Replacement(GOOGLE_CONTEXTUAL_SEARCH_START, start));
+ } else if (parameter == kGoogleContextualSearchEnd) {
+ replacements->push_back(
+ Replacement(GOOGLE_CONTEXTUAL_SEARCH_END, start));
+ } else if (parameter == kGoogleContextualSearchContent) {
+ replacements->push_back(
+ Replacement(GOOGLE_CONTEXTUAL_SEARCH_CONTENT, start));
+ } else if (parameter == kGoogleContextualSearchBasePageURL) {
+ replacements->push_back(
+ Replacement(GOOGLE_CONTEXTUAL_SEARCH_BASE_PAGE_URL, start));
+ } else if (parameter == kGoogleContextualSearchEncoding) {
+ replacements->push_back(
+ Replacement(GOOGLE_CONTEXTUAL_SEARCH_ENCODING, start));
} else if (parameter == kGoogleOriginalQueryForSuggestionParameter) {
replacements->push_back(Replacement(GOOGLE_ORIGINAL_QUERY_FOR_SUGGESTION,
start));
@@ -928,6 +959,58 @@ std::string TemplateURLRef::HandleReplacements(
}
break;
+ case GOOGLE_CONTEXTUAL_SEARCH_VERSION:
+ if (search_terms_args.contextual_search_params.version >= 0) {
+ HandleReplacement(
+ "ctxs",
+ base::IntToString(
+ search_terms_args.contextual_search_params.version),
+ *i,
+ &url);
+ }
+ break;
+
+ case GOOGLE_CONTEXTUAL_SEARCH_START:
+ HandleReplacement(
+ std::string(),
+ base::IntToString(search_terms_args.contextual_search_params.start),
+ *i,
+ &url);
+ break;
+
+ case GOOGLE_CONTEXTUAL_SEARCH_END:
+ HandleReplacement(
+ std::string(),
+ base::IntToString(search_terms_args.contextual_search_params.end),
+ *i,
+ &url);
+ break;
+
+ case GOOGLE_CONTEXTUAL_SEARCH_CONTENT: {
+ HandleReplacement(
+ std::string(),
+ search_terms_args.contextual_search_params.content,
+ *i,
+ &url);
+ break;
+ }
+
+ case GOOGLE_CONTEXTUAL_SEARCH_BASE_PAGE_URL: {
+ const std::string base_page_url =
+ search_terms_args.contextual_search_params.base_page_url;
+ if (!base_page_url.empty())
+ HandleReplacement("ctxs_url", base_page_url, *i, &url);
+ break;
+ }
+
+ case GOOGLE_CONTEXTUAL_SEARCH_ENCODING: {
+ const std::string encoding =
+ search_terms_args.contextual_search_params.encoding;
+ if (!encoding.empty())
+ HandleReplacement("ctxs_encoding", encoding, *i, &url);
+ break;
+ }
+
case GOOGLE_ORIGINAL_QUERY_FOR_SUGGESTION:
DCHECK(!i->is_post_param);
if (search_terms_args.accepted_suggestion >= 0 ||
@@ -1099,7 +1182,8 @@ TemplateURL::TemplateURL(Profile* profile, const TemplateURLData& data)
instant_url_ref_(this,
TemplateURLRef::INSTANT),
image_url_ref_(this, TemplateURLRef::IMAGE),
- new_tab_url_ref_(this, TemplateURLRef::NEW_TAB) {
+ new_tab_url_ref_(this, TemplateURLRef::NEW_TAB),
+ contextual_search_url_ref_(this, TemplateURLRef::CONTEXTUAL_SEARCH) {
SetPrepopulateId(data_.prepopulate_id);
if (data_.search_terms_replacement_key ==

Powered by Google App Engine
This is Rietveld 408576698