chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc - Issue 308053009: Add contextual search to the template url system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

Issue 308053009: Add contextual search to the template url system (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/search_engines/template_url.cc ('K') | « chrome/browser/search_engines/template_url_prepopulate_data.cc ('k') | chrome/browser/search_engines/template_url_unittest.cc » ('j') | chrome/browser/search_engines/template_url_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

diff --git a/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc b/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

index f58fa97512f30c9ababa5559c217f6edd09f7579..a0a7a3d4f12e40ab5bfb3dc3ac83c9a4ba10c935 100644

--- a/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

+++ b/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

@@ -238,6 +238,7 @@ TEST(TemplateURLPrepopulateDataTest, ClearProvidersFromPrefs) {

EXPECT_FALSE(t_urls[default_index]->instant_url.empty());

EXPECT_FALSE(t_urls[default_index]->image_url.empty());

EXPECT_FALSE(t_urls[default_index]->new_tab_url.empty());

+ EXPECT_FALSE(t_urls[default_index]->contextual_search_url.empty());

EXPECT_FALSE(t_urls[default_index]->image_url_post_params.empty());

EXPECT_EQ(SEARCH_ENGINE_GOOGLE,

TemplateURLPrepopulateData::GetEngineType(

@@ -271,6 +272,7 @@ TEST(TemplateURLPrepopulateDataTest, ProvidersFromPrepopulated) {

EXPECT_FALSE(t_urls[default_index]->instant_url.empty());

EXPECT_FALSE(t_urls[default_index]->image_url.empty());

EXPECT_FALSE(t_urls[default_index]->new_tab_url.empty());

+ EXPECT_FALSE(t_urls[default_index]->contextual_search_url.empty());

EXPECT_FALSE(t_urls[default_index]->image_url_post_params.empty());

// Expect at least 2 alternate_urls.

// This caught a bug with static initialization of arrays, so leave this in.