Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 308053008: Simplifies ShellTestHelper and ViewManager tests (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Simplifies ShellTestHelper and ViewManager tests ShellTestHelper doesn't need to spawn a thread. Nuking the thread simplifies the view manager tests. BUG=365012 TEST=covered by tests R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274167

Patch Set 1 #

Patch Set 2 : more cleanup #

Patch Set 3 : merge to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -261 lines) Patch
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 2 12 chunks +59 lines, -180 lines 0 comments Download
M mojo/shell/shell_test_helper.h View 1 3 chunks +7 lines, -19 lines 0 comments Download
M mojo/shell/shell_test_helper.cc View 1 2 2 chunks +7 lines, -62 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sky
6 years, 6 months ago (2014-05-30 21:55:49 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 6 months ago (2014-05-30 22:00:27 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-05-30 22:02:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/308053008/10001
6 years, 6 months ago (2014-05-30 22:05:05 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-31 03:11:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-31 04:31:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/158579)
6 years, 6 months ago (2014-05-31 04:31:24 UTC) #7
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-01 19:48:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/308053008/30001
6 years, 6 months ago (2014-06-01 19:49:01 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 05:34:23 UTC) #10
Message was sent while issue was closed.
Change committed as 274167

Powered by Google App Engine
This is Rietveld 408576698