chrome/renderer/extensions/notifications_native_handler.cc - Issue 308053004: Add appIconMask to notification API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/notifications_native_handler.cc

Issue 308053004: Add appIconMask to notification API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/notifications_native_handler.cc

diff --git a/chrome/renderer/extensions/notifications_native_handler.cc b/chrome/renderer/extensions/notifications_native_handler.cc

index ba0e17a5252be0ad9b5141e9a4d828c647c4b18f..0100fbd77e73ded97bfa95b11f37d448b108389b 100644

--- a/chrome/renderer/extensions/notifications_native_handler.cc

+++ b/chrome/renderer/extensions/notifications_native_handler.cc

@@ -38,6 +38,10 @@ void NotificationsNativeHandler::GetNotificationImageSizes(

dict->SetInteger("image.height", bitmap_sizes.image_size.height());

dict->SetInteger("buttonIcon.width", bitmap_sizes.button_icon_size.width());

dict->SetInteger("buttonIcon.height", bitmap_sizes.button_icon_size.height());

+ dict->SetInteger("appIconMask.width",

+ bitmap_sizes.app_icon_mask_size.width());

+ dict->SetInteger("appIconMask.height",

+ bitmap_sizes.app_icon_mask_size.height());

scoped_ptr<content::V8ValueConverter> converter(

content::V8ValueConverter::create());