chrome/renderer/resources/extensions/notifications_custom_bindings.js - Issue 308053004: Add appIconMask to notification API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/notifications_custom_bindings.js

Issue 308053004: Add appIconMask to notification API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/notifications.idl ('K') | « chrome/renderer/extensions/notifications_native_handler.cc ('k') | ui/message_center/message_center.gyp » ('j') | ui/message_center/views/small_image_mask.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/notifications_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/notifications_custom_bindings.js b/chrome/renderer/resources/extensions/notifications_custom_bindings.js

index 013628abff281af8a238a343e2793c12a5e98b9c..fb4f1f37e18893e1f60c7f2cdf6e99d2e28d2b7b 100644

--- a/chrome/renderer/resources/extensions/notifications_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/notifications_custom_bindings.js

@@ -40,6 +40,16 @@ function getUrlSpecs(imageSizes, notificationDetails) {

});

}

+ // |smallIconUrl| is optional.

+ if (notificationDetails.smallIconUrl) {

+ $Array.push(urlSpecs, {

+ path: notificationDetails.smallIconUrl,

+ width: imageSizes.smallIcon.width * imageSizes.scaleFactor,

+ height: imageSizes.smallIcon.height * imageSizes.scaleFactor,

+ callback: imageDataSetter(notificationDetails, 'smallIconBitmap')

+ });

+ }

// |imageUrl| is optional.

if (notificationDetails.imageUrl) {

$Array.push(urlSpecs, {