Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 308043007: Aura does not need to depend on gpu target. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

Aura does not need to depend on gpu target. A grep for gpu reveals that only ui/aura/bench includes from gpu. Change aura_bench to depend on gles2_implementation. That should simplify the conversion of Aura to GN. BUG=None TEST=green trybots TBR=ben@chromium.org,brettw@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/aura/aura.gyp View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
TBRing...(will land after green trybots and building locally).
6 years, 6 months ago (2014-05-31 04:59:57 UTC) #1
brettw
LGTM but I'm not an owner of this dir.
6 years, 6 months ago (2014-05-31 05:52:04 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-05-31 06:29:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/308043007/1
6 years, 6 months ago (2014-05-31 06:30:22 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 23:00:13 UTC) #5
Message was sent while issue was closed.
Change committed as 274087

Powered by Google App Engine
This is Rietveld 408576698