Allow downsampling of output from a MediaStream video track to arbitrary max video size.

Allow downsampling of output from a MediaStream video track to arbitrary max video size.
Since we now scale video instead of cropping video when multiple tracks use the same source,
it is no longer necessary to limit the downscaling to max a factor of two.

BUG=346616
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273893

[perkj_chrome, 2014-05-30 13:24:53]

Can you please review?

[mcasas, 2014-05-30 13:31:57]

https://codereview.chromium.org/308043003/diff/1/content/renderer/media/media...
File content/renderer/media/media_stream_video_source.cc (right):

https://codereview.chromium.org/308043003/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_video_source.cc:169: return value > 0;
Shouldn't we:
return value > kMinimumPossibleFrameWidth?

(Assuming |kMinimumPossibleFrameWidth| exists).

https://codereview.chromium.org/308043003/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_video_source.cc:173: return value > 0;
return value > kMaximumPossibleFrameWidth?

(Assuming |kMaximumPossibleFrameWidth| exists).

[perkj_chrome, 2014-05-30 13:36:25]

On 2014/05/30 13:31:57, mcasas wrote:
>
https://codereview.chromium.org/308043003/diff/1/content/renderer/media/media...
> File content/renderer/media/media_stream_video_source.cc (right):
> 
>
https://codereview.chromium.org/308043003/diff/1/content/renderer/media/media...
> content/renderer/media/media_stream_video_source.cc:169: return value > 0;
> Shouldn't we:
> return value > kMinimumPossibleFrameWidth?
> 
> (Assuming |kMinimumPossibleFrameWidth| exists).
> 
>
https://codereview.chromium.org/308043003/diff/1/content/renderer/media/media...
> content/renderer/media/media_stream_video_source.cc:173: return value > 0;
> return value > kMaximumPossibleFrameWidth?
> 
> (Assuming |kMaximumPossibleFrameWidth| exists).

I don't think that exist. So this cl make it possible for JS to set the max
widht height to whatever the app developer wants. It does not mean it will get
exactly that- it only means we will try to scale / crop to that size.

[mcasas, 2014-05-30 14:14:20]

LGTM then.

[perkj_chrome, 2014-05-30 14:18:07]

The CQ bit was checked by perkj@chromium.org

[commit-bot: I haz the power, 2014-05-30 14:19:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/perkj@chromium.org/308043003/1

[commit-bot: I haz the power, 2014-05-30 17:52:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-30 19:55:15]

Change committed as 273893