gpu testing: Fix viewport initial-scale for pixel tests.

gpu testing: Fix viewport initial-scale for pixel tests.

Fix the zoom level so that the layout is predictable. Otherwise tests
that sample pixels would sample incorrect pixels.

BUG=368495
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273755

[bajones, 2014-05-29 22:32:31]

This fix looks good, but wouldn't we want to make the same viewport adjustment
to pixel_canvas2d.html and pixel_webgl.html?

[alokp, 2014-05-29 22:42:26]

We are not sampling pixels for those tests, so it is not required but would not
hurt either.

[Ken Russell (switch to Gerrit), 2014-05-29 22:42:30]

lgtm

https://codereview.chromium.org/308033002/diff/1/content/test/data/gpu/pixel_...
File content/test/data/gpu/pixel_css3d.html (right):

https://codereview.chromium.org/308033002/diff/1/content/test/data/gpu/pixel_...
content/test/data/gpu/pixel_css3d.html:11: <meta name="viewport"
content="initial-scale=1">
Please double-check that this doesn't affect the tests on desktop platforms in a
surprising way.

https://codereview.chromium.org/308033002/diff/1/content/test/gpu/page_sets/p...
File content/test/gpu/page_sets/pixel_tests.py (right):

https://codereview.chromium.org/308033002/diff/1/content/test/gpu/page_sets/p...
content/test/gpu/page_sets/pixel_tests.py:45: revision=7,
You'll need to mark this test as failing on all platforms in
src/content/test/gpu/gpu_tests/pixel_expectations.py in this CL, and then land
another CL through the commit queue which unmarks it as failing. Please see
http://www.chromium.org/developers/testing/gpu-testing#TOC-Updating-and-Addin...
.

[alokp, 2014-05-29 22:56:13]

https://codereview.chromium.org/308033002/diff/1/content/test/data/gpu/pixel_...
File content/test/data/gpu/pixel_css3d.html (right):

https://codereview.chromium.org/308033002/diff/1/content/test/data/gpu/pixel_...
content/test/data/gpu/pixel_css3d.html:11: <meta name="viewport"
content="initial-scale=1">
On 2014/05/29 22:42:31, Ken Russell wrote:
> Please double-check that this doesn't affect the tests on desktop platforms in
a
> surprising way.

Tested it on mac and linux. Works as expected.

https://codereview.chromium.org/308033002/diff/1/content/test/gpu/page_sets/p...
File content/test/gpu/page_sets/pixel_tests.py (right):

https://codereview.chromium.org/308033002/diff/1/content/test/gpu/page_sets/p...
content/test/gpu/page_sets/pixel_tests.py:45: revision=7,
On 2014/05/29 22:42:31, Ken Russell wrote:
> You'll need to mark this test as failing on all platforms in
> src/content/test/gpu/gpu_tests/pixel_expectations.py in this CL, and then land
> another CL through the commit queue which unmarks it as failing. Please see
>
http://www.chromium.org/developers/testing/gpu-testing#TOC-Updating-and-Addin...
> .

Done.

[alokp, 2014-05-29 22:57:07]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2014-05-29 22:59:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alokp@chromium.org/308033002/20001

[commit-bot: I haz the power, 2014-05-30 07:30:17]

Change committed as 273755