ARM64: Fix ASM_LOCATION and the like.

ARM64: Fix ASM_LOCATION and the like.

BUG=
R=ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21620

[ulan, 2014-06-02 12:48:56]

https://codereview.chromium.org/308023007/diff/1/src/checks.h
File src/checks.h (right):

https://codereview.chromium.org/308023007/diff/1/src/checks.h#newcode34
src/checks.h:34: #if V8_TARGET_ARCH_ARM64 && !V8_HOST_ARCH_ARM64
I think this branch is now active for cross-compiled binaries that do not
necessarily use simulator.

[jbramley, 2014-06-02 12:52:37]

https://codereview.chromium.org/308023007/diff/1/src/checks.h
File src/checks.h (right):

https://codereview.chromium.org/308023007/diff/1/src/checks.h#newcode34
src/checks.h:34: #if V8_TARGET_ARCH_ARM64 && !V8_HOST_ARCH_ARM64
On 2014/06/02 12:48:56, ulan wrote:
> I think this branch is now active for cross-compiled binaries that do not
> necessarily use simulator.

You might be right, but that is how USE_SIMULATOR is defined in globals.h. I'll
do a cross-build and see what happens.

[jbramley, 2014-06-02 17:07:13]

On 2014/06/02 12:52:37, jbramley wrote:
> https://codereview.chromium.org/308023007/diff/1/src/checks.h
> File src/checks.h (right):
> 
> https://codereview.chromium.org/308023007/diff/1/src/checks.h#newcode34
> src/checks.h:34: #if V8_TARGET_ARCH_ARM64 && !V8_HOST_ARCH_ARM64
> On 2014/06/02 12:48:56, ulan wrote:
> > I think this branch is now active for cross-compiled binaries that do not
> > necessarily use simulator.
> 
> You might be right, but that is how USE_SIMULATOR is defined in globals.h.
I'll
> do a cross-build and see what happens.

Ok, my first patch was broken, as you noted. V8_TARGET_ARCH_ARM64 and
V8_HOST_ARCH_ARM64 are the right macros to use (even for cross builds), but
V8_HOST_ARCH_ARM64 is defined automatically in base/build_config.h, and isn't
defined by this point in src/checks.h. I've uploaded a new patch that includes
this header, and it now behaves as expected.

[ulan, 2014-06-03 07:19:02]

Thank you for checking it with cross builds. LGTM.

[jbramley, 2014-06-03 07:37:22]

Committed patchset #2 manually as r21620 (presubmit successful).