Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 308023003: Don't call splitTreeToNode() with null Node (Closed)

Created:
6 years, 6 months ago by yosin_UTC9
Modified:
6 years, 6 months ago
Reviewers:
yoichio, Yuta Kitamura
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Don't call splitTreeToNode() with null Node This patch changes |IndentOutdentCommand::outdentParagraph()| to check whether |enclosingBlockNode| is null or not, before passing it to |CompositeEditCommand::splitTreeToNode()| which assumes it isn't null. This situation can be happened in attach test case, where |enclosingBlockNode| is calculated from |visibleStartOfParagraph|, which is second TABLE element, by |enclosingBlock()|. BUG=378758 TEST=editing/execCommand/outdent-collapse-table-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175251

Patch Set 1 : 2014-05-30T05:17:51 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
A LayoutTests/editing/execCommand/outdent-collapse-table-crash.html View 1 chunk +34 lines, -0 lines 0 comments Download
A + LayoutTests/editing/execCommand/outdent-collapse-table-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/editing/IndentOutdentCommand.cpp View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance. Note: blink_android_compile_{dbg,rel} and mac_blink_rel compilation failures aren't ...
6 years, 6 months ago (2014-05-30 13:19:54 UTC) #1
yosin_UTC9
Could you review this patch? Thanks in advance. Note: blink_android_compile_{dbg,rel} and mac_blink_rel compilation failures aren't ...
6 years, 6 months ago (2014-05-30 13:20:36 UTC) #2
Yuta Kitamura
lgtm
6 years, 6 months ago (2014-06-02 03:04:04 UTC) #3
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 6 months ago (2014-06-02 03:33:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/308023003/20001
6 years, 6 months ago (2014-06-02 03:33:24 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-02 03:34:32 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 03:45:41 UTC) #7
Message was sent while issue was closed.
Change committed as 175251

Powered by Google App Engine
This is Rietveld 408576698