Pepper: Narrow locking at llc subprocess start.

Pepper: Narrow locking at llc subprocess start.

Currently, subprocess_mu_ is held the entire time the llc subprocess is
starting. This blocks a larger refactor that I'd like to make as part of nexe
loading.

I'd like to change ServiceRuntime::LoadModule() to be asynchronous to simplify
threading behavior on the plugin side when loading nexe modules. However, this
requires that many methods are made asynchronous, including
Plugin::LoadHelperNaClModule().

PnaclTranslateThread will need to use a pattern similar to WaitForSelLdrStart()
to resume execution on a background thread. However, I don't like the idea of
introducing another mutex and condvar to deal with while holding
subprocess_mu_.

This change narrows the time that subprocess_mu_ is held to make that refactor
possible. I'll make a similar change for the ld subprocess, but I wanted to get
this reviewed before proceeding further.

BUG=333950
R=bbudge@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273895

[teravest, 2014-05-30 16:26:45]

-dmichael +bbudge

[bbudge, 2014-05-30 17:53:19]

LGTM

https://codereview.chromium.org/308013002/diff/1/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc (right):

https://codereview.chromium.org/308013002/diff/1/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc:178:
"NaCl.Perf.PNaClLoadTime.LoadCompiler",
nit: indent arguments

[teravest, 2014-05-30 17:55:49]

Thanks!

On Fri, May 30, 2014 at 11:53 AM,  <bbudge@chromium.org> wrote:
> LGTM
>
>
>
https://codereview.chromium.org/308013002/diff/1/ppapi/native_client/src/trus...
> File ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
> (right):
>
>
https://codereview.chromium.org/308013002/diff/1/ppapi/native_client/src/trus...
> ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc:178:
> "NaCl.Perf.PNaClLoadTime.LoadCompiler",
> nit: indent arguments

Done.

>
> https://codereview.chromium.org/308013002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[teravest, 2014-05-30 18:11:21]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-05-30 18:12:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/teravest@chromium.org/308013002/20001

[teravest, 2014-05-30 20:00:14]

Committed patchset #2 manually as r273895 (presubmit successful).