Autofill: Two small fixes.

Autofill: Two small fixes.

- Remove unnecessary "Summary" line from Autofill options dialog box.

- Make the sub-dialogs ('Add an address' and 'Add a credit card') modal.

BUG=49881, 49787
TEST=Go to Options > Personal Stuff > AutoFill Options. The listview shouldn't have any header. Click on 'Add address...' or in 'Add credit card...', try to come back to the AutoFill options dialog again, it shouldn't be possible.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55527

[James Hawkins, 2010-08-09 16:45:49]

http://codereview.chromium.org/3080039/diff/9002/10002
File chrome/browser/views/autofill_profiles_view_win.h (right):

http://codereview.chromium.org/3080039/diff/9002/10002#newcode261
chrome/browser/views/autofill_profiles_view_win.h:261: virtual bool IsModal()
const { return true; }
What is the impetus for this change?

[tfarina, 2010-08-09 16:51:57]

On Mon, Aug 9, 2010 at 1:45 PM,  <jhawkins@chromium.org> wrote:
>
> http://codereview.chromium.org/3080039/diff/9002/10002
> File chrome/browser/views/autofill_profiles_view_win.h (right):
>
> http://codereview.chromium.org/3080039/diff/9002/10002#newcode261
> chrome/browser/views/autofill_profiles_view_win.h:261: virtual bool
> IsModal() const { return true; }
> What is the impetus for this change?
>

You said in the bug:
"It sounds like the problem is that the sub-dialog is non-modal when
it should be modal."

Quoting the principal: "it should be modal".

So that was the motivation.

Why it sounds wrong?

-- 
A: Because it messes up the order in which people normally read text.
 See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

-Thiago

[James Hawkins, 2010-08-09 17:18:27]

On 2010/08/09 16:51:57, tfarina wrote:
> On Mon, Aug 9, 2010 at 1:45 PM,  <mailto:jhawkins@chromium.org> wrote:
> >
> > http://codereview.chromium.org/3080039/diff/9002/10002
> > File chrome/browser/views/autofill_profiles_view_win.h (right):
> >
> > http://codereview.chromium.org/3080039/diff/9002/10002#newcode261
> > chrome/browser/views/autofill_profiles_view_win.h:261: virtual bool
> > IsModal() const { return true; }
> > What is the impetus for this change?
> >
> 
> You said in the bug:
> "It sounds like the problem is that the sub-dialog is non-modal when
> it should be modal."
> 
> Quoting the principal: "it should be modal".
> 
> So that was the motivation.
> 
> Why it sounds wrong?
> 

It doesn't, just needed a refresher :-)

LGTM