Chromium Code Reviews| Index: chrome/browser/views/autofill_profiles_view_win.h |
| diff --git a/chrome/browser/views/autofill_profiles_view_win.h b/chrome/browser/views/autofill_profiles_view_win.h |
| index ced194335dce555d305663e1aba69dcb931dd6d9..77ce90052a82fc68a4d447b1d2c469cd5d6b9456 100644 |
| --- a/chrome/browser/views/autofill_profiles_view_win.h |
| +++ b/chrome/browser/views/autofill_profiles_view_win.h |
| @@ -30,7 +30,7 @@ class Label; |
| class RadioButton; |
| class TableView; |
| class TextButton; |
| -} |
| +} // namespace views |
| class PrefService; |
| class SkBitmap; |
| @@ -68,7 +68,7 @@ class AutoFillProfilesView : public views::View, |
| CreditCard* imported_credit_card); |
| protected: |
| - // forward declaration. This struct defined further down. |
| + // Forward declaration. This struct defined further down. |
| struct EditableSetInfo; |
| // Called when 'Add Address' (|group_type| is |
| // ContentListTableModel::kAddressGroup) or 'Add Credit Card' (|group_type| is |
| @@ -226,7 +226,7 @@ class AutoFillProfilesView : public views::View, |
| DISALLOW_COPY_AND_ASSIGN(PhoneSubView); |
| }; |
| - // forward declaration |
| + // Forward declaration. |
| class AddressComboBoxModel; |
| class StringVectorComboboxModel; |
| @@ -258,7 +258,7 @@ class AutoFillProfilesView : public views::View, |
| MessageBoxFlags::DialogButton button) const; |
| virtual bool CanResize() const { return false; } |
| virtual bool CanMaximize() const { return false; } |
| - virtual bool IsAlwaysOnTop() const { return false; } |
| + virtual bool IsModal() const { return true; } |
|
James Hawkins
2010/08/09 16:45:49
What is the impetus for this change?
|
| virtual bool HasAlwaysOnTopMenu() const { return false; } |
| virtual std::wstring GetWindowTitle() const; |
| virtual void WindowClosing(); |
| @@ -268,7 +268,7 @@ class AutoFillProfilesView : public views::View, |
| // views::ButtonListener methods: |
| virtual void ButtonPressed(views::Button* sender, |
| - const views::Event& event); |
| + const views::Event& event); |
| // views::Textfield::Controller methods: |
| virtual void ContentsChanged(views::Textfield* sender, |
| @@ -295,7 +295,7 @@ class AutoFillProfilesView : public views::View, |
| TEXT_FAX_PHONE, |
| TEXT_CC_NAME, |
| TEXT_CC_NUMBER, |
| - // must be last |
| + // Must be last. |
| MAX_TEXT_FIELD |
| }; |
| @@ -346,7 +346,7 @@ class AutoFillProfilesView : public views::View, |
| DISALLOW_COPY_AND_ASSIGN(EditableSetViewContents); |
| }; |
| - // Encapsulates ComboboxModel for address |
| + // Encapsulates ComboboxModel for address. |
| class AddressComboBoxModel : public ComboboxModel { |
| public: |
| explicit AddressComboBoxModel(bool is_billing); |
| @@ -372,7 +372,8 @@ class AutoFillProfilesView : public views::View, |
| // Gets index of the item in the model or -1 if not found. |
| int GetIndex(int unique_id); |
| - // ComboboxModel methods, public as they used from EditableSetViewContents |
| + // Overridden from ComboboxModel: |
| + // Public as they are used from EditableSetViewContents. |
| virtual int GetItemCount(); |
| virtual std::wstring GetItemAt(int index); |
| @@ -393,10 +394,8 @@ class AutoFillProfilesView : public views::View, |
| // |source|. |
| void set_cb_strings(std::vector<std::wstring> *source); |
| - // Return the number of items in the combo box. |
| + // Overridden from ComboboxModel: |
| virtual int GetItemCount(); |
| - |
| - // Return the string that should be used to represent a given item. |
| virtual std::wstring GetItemAt(int index); |
| // Find an index of the item in the model, -1 if not present. |
| @@ -408,8 +407,7 @@ class AutoFillProfilesView : public views::View, |
| DISALLOW_COPY_AND_ASSIGN(StringVectorComboboxModel); |
| }; |
| - |
| - // Model for scrolling credit cards and addresses |
| + // Model for scrolling credit cards and addresses. |
| class ContentListTableModel : public TableModel { |
| public: |
| ContentListTableModel(std::vector<EditableSetInfo>* profiles, |
| @@ -468,4 +466,3 @@ class AutoFillProfilesView : public views::View, |
| }; |
| #endif // CHROME_BROWSER_VIEWS_AUTOFILL_PROFILES_VIEW_WIN_H_ |
| - |