Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2419)

Unified Diff: chrome/browser/resources/bookmark_manager/js/bmm.js

Issue 308003013: Make the Bookmark Manager aware of managed bookmarks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/bookmark_manager/js/bmm.js
diff --git a/chrome/browser/resources/bookmark_manager/js/bmm.js b/chrome/browser/resources/bookmark_manager/js/bmm.js
index 0d7c491f5df305db848fdb25a9f4cedabfad0c07..62a49463fd6766efc483ecfda21356f63852b6ae 100644
--- a/chrome/browser/resources/bookmark_manager/js/bmm.js
+++ b/chrome/browser/resources/bookmark_manager/js/bmm.js
@@ -4,6 +4,13 @@
cr.define('bmm', function() {
/**
+ * The id of the managed node.
+ * @type {string}
+ * @const
+ */
+ var MANAGED_NODE_ID = '4';
+
+ /**
* Whether a node contains another node.
* TODO(yosin): Once JavaScript style guide is updated and linter follows
* that, we'll remove useless documentations for |parent| and |descendant|.
@@ -30,6 +37,21 @@ cr.define('bmm', function() {
return !('url' in node);
}
+ /**
+ * @param {BookmarkTreeNode} node The node to test.
+ * @return {boolean} Whether the node is managed.
+ */
+ function isManaged(node) {
+ if (!node)
+ return false;
+ if (node.id === MANAGED_NODE_ID)
+ return true;
+ // The managed node may be invisible, in which case it won't exist in
+ // |bmm.treeLookup|.
+ var managedNode = bmm.treeLookup[MANAGED_NODE_ID];
+ return managedNode && bmm.contains(managedNode.bookmarkNode, node);
+ }
+
var loadingPromises = {};
/**
@@ -242,6 +264,7 @@ cr.define('bmm', function() {
return {
contains: contains,
isFolder: isFolder,
+ isManaged: isManaged,
loadSubtree: loadSubtree,
loadTree: loadTree,
addBookmarkModelListeners: addBookmarkModelListeners

Powered by Google App Engine
This is Rietveld 408576698