Make the Bookmark Manager aware of managed bookmarks.

chrome/browser/resources/bookmark_manager/js/main.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 /** @const */ var BookmarkList = bmm.BookmarkList;
 /** @const */ var BookmarkTree = bmm.BookmarkTree;
 /** @const */ var Command = cr.ui.Command;
 /** @const */ var CommandBinding = cr.ui.CommandBinding;
 /** @const */ var LinkKind = cr.LinkKind;
@@ skipping 437 matching lines @@
   switch (command.id) {
     case 'import-menu-command':
       e.canExecute = canEdit;
       break;
     case 'export-menu-command':
       // We can always execute the export-menu command.
       e.canExecute = true;
       break;
     case 'sort-command':
       e.canExecute = !list.isSearch() &&
-          list.dataModel && list.dataModel.length > 1;
+          list.dataModel && list.dataModel.length > 1 &&
+          !bmm.isManaged(tree.getBookmarkNodeById(list.parentId));
       break;
     case 'undo-command':
       // The global undo command has no visible UI, so always enable it, and
       // just make it a no-op if undo is not possible.
       e.canExecute = true;
       break;
     default:
       canExecuteForList(e);
       break;
   }
 }
 
 /**
  * Helper function for handling canExecute for the list and the tree.
  * @param {!Event} e Can execute event object.
  * @param {boolean} isSearch Whether the user is trying to do a command on
  *     search.
  */
 function canExecuteShared(e, isSearch) {
   var command = e.command;
   var commandId = command.id;
   switch (commandId) {
     case 'paste-from-organize-menu-command':
     case 'paste-from-context-menu-command':
       updatePasteCommand();
       break;
 
     case 'add-new-bookmark-command':
     case 'new-folder-command':
-      e.canExecute = !isSearch && canEdit;
+      var parentId = computeParentFolderForNewItem();
+      var isManaged = bmm.isManaged(tree.getBookmarkNodeById(parentId));
+      e.canExecute = !isSearch && canEdit && !isManaged;
       break;
 
     case 'open-in-new-tab-command':
       updateOpenCommand(e, command, 'open_in_new_tab', 'open_all', false);
       break;
     case 'open-in-background-tab-command':
       updateOpenCommand(e, command, '', '', false);
       break;
     case 'open-in-new-window-command':
       updateOpenCommand(e, command,
@@ skipping 45 matching lines @@
 
   switch (commandId) {
     case 'rename-folder-command':
       // Show rename if a single folder is selected.
       var items = list.selectedItems;
       if (items.length != 1) {
         e.canExecute = false;
         command.hidden = true;
       } else {
         var isFolder = bmm.isFolder(items[0]);
-        e.canExecute = isFolder && canEdit;
+        e.canExecute = isFolder && canEdit && !hasManaged(items);

[arv (Not doing code reviews), 2014/06/03 14:31:39]

Can't this just check if the list is managed since all the items in the list
have the same logical parent (except for the search result).

[Joao da Silva, 2014/06/05 20:28:38]

The isManaged check needs a BookmarkTreeNode, I'm not sure how we can get the
parent of all of the list's elements...

         command.hidden = !isFolder;
       }
       break;
 
     case 'edit-command':
       // Show the edit command if not a folder.
       var items = list.selectedItems;
       if (items.length != 1) {
         e.canExecute = false;
         command.hidden = false;
       } else {
         var isFolder = bmm.isFolder(items[0]);
-        e.canExecute = !isFolder && canEdit;
+        e.canExecute = !isFolder && canEdit && !hasManaged(items);
         command.hidden = isFolder;
       }
       break;
 
     case 'show-in-folder-command':
       e.canExecute = isSearch() && hasSingleSelected();
       break;
 
     case 'delete-command':
     case 'cut-command':
-      e.canExecute = canCopyItems() && canEdit;
+      e.canExecute = canCopyItems() && canEdit &&
+          !hasManaged(list.selectedItems);
       break;
 
     case 'copy-command':
       e.canExecute = canCopyItems();
       break;
 
     case 'open-in-same-window-command':
       e.canExecute = hasSelected();
       break;
 
@@ skipping 24 matching lines @@
     return item == searchTreeItem;
   }
 
   function isTopLevelItem() {
     return e.target.selectedItem.parentNode == tree;
   }
 
   switch (commandId) {
     case 'rename-folder-command':
       command.hidden = false;
-      e.canExecute = hasSelected() && !isTopLevelItem() && canEdit;
+      e.canExecute = hasSelected() && !isTopLevelItem() && canEdit &&
+          !hasManaged(tree.selectedFolders);
       break;
 
     case 'edit-command':
       command.hidden = true;
       e.canExecute = false;
       break;
 
     case 'delete-command':
     case 'cut-command':
-      e.canExecute = hasSelected() && !isTopLevelItem() && canEdit;
+      e.canExecute = hasSelected() && !isTopLevelItem() && canEdit &&
+          !hasManaged(tree.selectedFolders);
       break;
 
     case 'copy-command':
       e.canExecute = hasSelected() && !isTopLevelItem();
       break;
 
     default:
       canExecuteShared(e, isSearch());
   }
 }
@@ skipping 139 matching lines @@
  */
 function getSelectedBookmarkIds() {
   var selectedNodes = getSelectedBookmarkNodes();
   selectedNodes.sort(function(a, b) { return a.index - b.index });
   return selectedNodes.map(function(node) {
     return node.id;
   });
 }
 
 /**
+ * @param {BookmarkList} A list of BookmarkNodes.
+ * @return {boolean} Whether any of the nodes is managed.
+ */
+function hasManaged(nodes) {
+  return nodes.some(bmm.isManaged);
+}
+
+/**
  * Opens the selected bookmarks.
  * @param {LinkKind} kind The kind of link we want to open.
  * @param {HTMLElement} opt_eventTarget The target of the user initiated event.
  */
 function openBookmarks(kind, opt_eventTarget) {
   // If we have selected any folders, we need to find all the bookmarks one
   // level down. We use multiple async calls to getSubtree instead of getting
   // the whole tree since we would like to minimize the amount of data sent.
 
   var urlsP = getUrlsForOpenCommands(opt_eventTarget);
@@ skipping 552 matching lines @@
 
   cr.ui.FocusOutlineManager.forDocument(document);
   initializeSplitter();
   bmm.addBookmarkModelListeners();
   dnd.init(selectItemsAfterUserAction);
   tree.reload();
 }
 
 initializeBookmarkManager();
 })();