Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 308003010: Fix typo cflags->ldflags in nss BUILD.gn on mac (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix typo cflags->ldflags in nss BUILD.gn on mac The gyp file has this in OTHER_LDFLAGS. TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/secondary/third_party/nss/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-01 01:08:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/308003010/1
6 years, 6 months ago (2014-06-01 01:08:27 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-01 02:38:21 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-01 02:38:33 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/19528)
6 years, 6 months ago (2014-06-01 02:38:33 UTC) #5
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-01 15:15:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/308003010/1
6 years, 6 months ago (2014-06-01 15:15:20 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-01 17:15:50 UTC) #8
Message was sent while issue was closed.
Change committed as 274123

Powered by Google App Engine
This is Rietveld 408576698