Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5121)

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 308003005: app_list: Drive app integration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase, fix nits Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index aedc100b3e2e5abcbb5a7be9949fe0eb15baab85..e94d1b762df4f08644efa11c078d9efbdd7db8d4 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -227,21 +227,18 @@ void CrxInstaller::ConvertUserScriptOnFileThread() {
void CrxInstaller::InstallWebApp(const WebApplicationInfo& web_app) {
NotifyCrxInstallBegin();
+ // Web apps can only ever be converted to bookmark apps.
+ DCHECK(creation_flags_ & Extension::FROM_BOOKMARK);
if (!installer_task_runner_->PostTask(
FROM_HERE,
- base::Bind(&CrxInstaller::ConvertWebAppOnFileThread,
- this,
- web_app,
- install_directory_)))
+ base::Bind(&CrxInstaller::ConvertWebAppOnFileThread, this, web_app)))
NOTREACHED();
}
void CrxInstaller::ConvertWebAppOnFileThread(
- const WebApplicationInfo& web_app,
- const base::FilePath& install_directory) {
- base::string16 error;
- scoped_refptr<Extension> extension(
- ConvertWebAppToExtension(web_app, base::Time::Now(), install_directory));
+ const WebApplicationInfo& web_app) {
+ scoped_refptr<Extension> extension(ConvertWebAppToExtension(
+ web_app, base::Time::Now(), creation_flags_, install_directory_));
if (!extension.get()) {
// Validation should have stopped any potential errors before getting here.
NOTREACHED() << "Could not convert web app to extension.";

Powered by Google App Engine
This is Rietveld 408576698