app_list: Drive app integration.

chrome/browser/extensions/crx_installer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 179 matching lines @@
       install_flags_ &= ~kInstallFlagInstallImmediately;
   }
 
   void set_is_ephemeral(bool val) {
     if (val)
       install_flags_ |= kInstallFlagIsEphemeral;
     else
       install_flags_ &= ~kInstallFlagIsEphemeral;
   }
 
   void set_install_flag(int flag, bool val) {

[not at google - send to devlin, 2014/06/17 21:15:19]

in the other CL I lgtm'd without looking at the last patchset. this isn't really
what I meant, I was imagining:

public:
void set_install_immediately(bool val) {
  set_install_flag(kInstallFlagInstallImmediately, val);
}
void set_is_ephemeral(bool val) {
  set_install_flag(kInstallFlagIsEphemeral, val);
}
void set_do_not_sync(bool val) {
  set_install_flag(kInstallFlagDoNotSync, val);
}

private:
void set_install_flag(int flag, bool val) {
  ...
}

[xiyuan, 2014/06/17 21:48:03]

Done.

     if (val)
       install_flags_ |= flag;
     else
       install_flags_ &= ~flag;
   }
 
   bool did_handle_successfully() const { return did_handle_successfully_; }
 
   Profile* profile() { return installer_.profile(); }
 
   const Extension* extension() { return installer_.extension().get(); }
 
+  const std::string& current_version() const { return current_version_; }
+
  private:
   friend class ::ExtensionServiceTest;
   friend class ExtensionUpdaterTest;
   friend class ExtensionCrxInstallerTest;
 
   CrxInstaller(base::WeakPtr<ExtensionService> service_weak,
                scoped_ptr<ExtensionInstallPrompt> client,
                const WebstoreInstaller::Approval* approval);
   virtual ~CrxInstaller();
 
   // Converts the source user script to an extension.
   void ConvertUserScriptOnFileThread();
 
   // Converts the source web app to an extension.
-  void ConvertWebAppOnFileThread(const WebApplicationInfo& web_app,
-                                 const base::FilePath& install_directory);
+  void ConvertWebAppOnFileThread(const WebApplicationInfo& web_app);
 
   // Called after OnUnpackSuccess as a last check to see whether the install
   // should complete.
   CrxInstallerError AllowInstall(const Extension* extension);
 
   // SandboxedUnpackerClient
   virtual void OnUnpackFailure(const base::string16& error_message) OVERRIDE;
   virtual void OnUnpackSuccess(const base::FilePath& temp_dir,
                                const base::FilePath& extension_dir,
                                const base::DictionaryValue* original_manifest,
@@ skipping 40 matching lines @@
   // and needs additional permissions.
   void ConfirmReEnable();
 
   // The file we're installing.
   base::FilePath source_file_;
 
   // The URL the file was downloaded from.
   GURL download_url_;
 
   // The directory extensions are installed to.
-  base::FilePath install_directory_;
+  const base::FilePath install_directory_;
 
   // The location the installation came from (bundled with Chromium, registry,
   // manual install, etc). This metadata is saved with the installation if
   // successful. Defaults to INTERNAL.
   Manifest::Location install_source_;
 
   // Indicates whether the user has already approved the extension to be
   // installed. If true, |expected_manifest_| and |expected_id_| must match
   // those of the CRX.
   bool approved_;
@@ skipping 122 matching lines @@
 
   // Gives access to common methods and data of an extension installer.
   ExtensionInstaller installer_;
 
   DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_