app_list: Drive app integration.

extensions/browser/extension_prefs.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_prefs.h"
 
 #include <iterator>
 
 #include "base/command_line.h"
 #include "base/prefs/pref_notifier.h"
@@ skipping 185 matching lines @@
 
 // A preference that stores the next threshold for displaying a notification
 // when an extension or app consumes excessive disk space. This will not be
 // set until the extension/app reaches the initial threshold.
 const char kPrefNextStorageThreshold[] = "next_storage_threshold";
 
 // If this preference is set to true, notifications will be suppressed when an
 // extension or app consumes excessive disk space.
 const char kPrefDisableStorageNotifications[] = "disable_storage_notifications";
 
+// A boolean preference that indicates whether the extension is allowed to be
+// synced. Default is true.

[not at google - send to devlin, 2014/06/06 01:26:29]

pet peeve is optional boolean values whose default value is true. can you phrase
this as a negation?

also: prefs go somewhere else these days, I can't remember... yoz@ ?

[Yoyo Zhou, 2014/06/06 01:39:27]

You mean this const char? It's fine to go here if it's only used in this file.

[xiyuan, 2014/06/06 04:12:37]

Changed the pref to "do_not_sync".

+const char kPrefIsSyncable[] = "is_syncable";
+
 // Provider of write access to a dictionary storing extension prefs.
 class ScopedExtensionPrefUpdate : public DictionaryPrefUpdate {
  public:
   ScopedExtensionPrefUpdate(PrefService* service,
                             const std::string& extension_id) :
     DictionaryPrefUpdate(service, pref_names::kExtensions),
     extension_id_(extension_id) {}
 
   virtual ~ScopedExtensionPrefUpdate() {
   }
@@ skipping 1520 matching lines @@
   }
   std::string install_time_str;
   if (!extension->GetString(kPrefInstallTime, &install_time_str))
     return base::Time();
   int64 install_time_i64 = 0;
   if (!base::StringToInt64(install_time_str, &install_time_i64))
     return base::Time();
   return base::Time::FromInternalValue(install_time_i64);
 }
 
+bool ExtensionPrefs::IsSyncable(const std::string& extension_id) const {
+  bool is_syncable;
+  if (!ReadPrefAsBoolean(extension_id, kPrefIsSyncable, &is_syncable))
+    return true;
+
+  return is_syncable;
+}
+
 base::Time ExtensionPrefs::GetLastLaunchTime(
     const std::string& extension_id) const {
   const base::DictionaryValue* extension = GetExtensionPref(extension_id);
   if (!extension)
     return base::Time();
 
   std::string launch_time_str;
   if (!extension->GetString(kPrefLastLaunchTime, &launch_time_str))
     return base::Time();
   int64 launch_time_i64 = 0;
@@ skipping 402 matching lines @@
   if (!install_parameter.empty()) {
     extension_dict->Set(kPrefInstallParam,
                         new base::StringValue(install_parameter));
   }
   // We store prefs about LOAD extensions, but don't cache their manifest
   // since it may change on disk.
   if (!Manifest::IsUnpackedLocation(extension->location())) {
     extension_dict->Set(kPrefManifest,
                         extension->manifest()->value()->DeepCopy());
   }
+
+  extension_dict->Set(kPrefIsSyncable,
+                      new base::FundamentalValue(extension->is_syncable()));

[not at google - send to devlin, 2014/06/06 01:26:29]

only set it if its value is non-default

[xiyuan, 2014/06/06 04:12:37]

Done.

 }
 
 void ExtensionPrefs::InitExtensionControlledPrefs(
     ExtensionPrefValueMap* value_map) {
   ExtensionIdList extension_ids;
   GetExtensions(&extension_ids);
 
   for (ExtensionIdList::iterator extension_id = extension_ids.begin();
        extension_id != extension_ids.end();
        ++extension_id) {
@@ skipping 83 matching lines @@
   extension_pref_value_map_->RegisterExtension(
       extension_id, install_time, is_enabled, is_incognito_enabled);
 
   FOR_EACH_OBSERVER(
       ExtensionPrefsObserver,
       observer_list_,
       OnExtensionRegistered(extension_id, install_time, is_enabled));
 }
 
 }  // namespace extensions