app_list: Drive app integration.

chrome/browser/extensions/crx_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/crx_installer.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 211 matching lines @@
     return;
   }
 
   OnUnpackSuccess(extension->path(), extension->path(), NULL, extension.get(),
                   SkBitmap());
 }
 
 void CrxInstaller::InstallWebApp(const WebApplicationInfo& web_app) {
   NotifyCrxInstallBegin();
 
+  const int creation_flags = creation_flags_ == Extension::NO_FLAGS
+                                 ? Extension::FROM_BOOKMARK

[not at google - send to devlin, 2014/06/05 16:54:05]

what does this mean?

[xiyuan, 2014/06/05 17:06:19]

This is to keep the current behavior, where Extension::FROM_BOOKMARK  is the
hardcoded flags of the URL app created from InstallWebApp and existing callers
of InstallWebApp does not specify any creation flags.

Would you prefer to update the existing callers instead? There are a couple of
them, I think.

[not at google - send to devlin, 2014/06/05 17:17:58]

Yes I would prefer that. DCHECK if you wish.

[xiyuan, 2014/06/05 17:48:32]

Done. Two callers: BookmarkAppHelper and AppLauncherHandler updated.

+                                 : creation_flags_;
   if (!installer_task_runner_->PostTask(
           FROM_HERE,
           base::Bind(&CrxInstaller::ConvertWebAppOnFileThread,
                      this,
                      web_app,
+                     creation_flags,
                      install_directory_)))
     NOTREACHED();
 }
 
 void CrxInstaller::ConvertWebAppOnFileThread(
     const WebApplicationInfo& web_app,
+    int creation_flags,
     const base::FilePath& install_directory) {
-  base::string16 error;
-  scoped_refptr<Extension> extension(
-      ConvertWebAppToExtension(web_app, base::Time::Now(), install_directory));
+  scoped_refptr<Extension> extension(ConvertWebAppToExtension(
+      web_app, base::Time::Now(), creation_flags, install_directory));
   if (!extension.get()) {
     // Validation should have stopped any potential errors before getting here.
     NOTREACHED() << "Could not convert web app to extension.";
     return;
   }
 
   // TODO(aa): conversion data gets lost here :(
 
   OnUnpackSuccess(extension->path(), extension->path(), NULL, extension.get(),
                   SkBitmap());
@@ skipping 650 matching lines @@
   if (!prefs->DidExtensionEscalatePermissions(extension()->id()))
     return;
 
   if (client_) {
     AddRef();  // Balanced in InstallUIProceed() and InstallUIAbort().
     client_->ConfirmReEnable(this, extension());
   }
 }
 
 }  // namespace extensions