Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 308003004: Remove runtime CPU detection for SSE optimized media/ methods. (Closed)

Created:
6 years, 6 months ago by DaleCurtis
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Remove runtime CPU detection for SSE optimized media/ methods. SSE2 is now the baseline for X86 platforms. BUG=378608 TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273964

Patch Set 1 #

Patch Set 2 : Remove vector math. #

Total comments: 1

Patch Set 3 : Rebase. Fix NaCl. #

Patch Set 4 : One more salty fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -337 lines) Patch
M media/base/media.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
D media/base/simd/sinc_resampler_sse.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D media/base/simd/vector_math_sse.cc View 1 1 chunk +0 lines, -118 lines 0 comments Download
M media/base/sinc_resampler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/sinc_resampler.cc View 4 chunks +45 lines, -35 lines 0 comments Download
M media/base/sinc_resampler_perftest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M media/base/sinc_resampler_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M media/base/vector_math.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M media/base/vector_math.cc View 1 2 3 2 chunks +111 lines, -40 lines 0 comments Download
M media/base/vector_math_perftest.cc View 1 7 chunks +5 lines, -30 lines 0 comments Download
M media/base/vector_math_testing.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/base/vector_math_unittest.cc View 1 4 chunks +0 lines, -4 lines 0 comments Download
M media/media.gyp View 1 4 chunks +0 lines, -38 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
DaleCurtis
+rileya since I know you love x86 assembly :)
6 years, 6 months ago (2014-05-29 22:03:47 UTC) #1
rileya (GONE FROM CHROMIUM)
On 2014/05/29 22:03:47, DaleCurtis wrote: > +rileya since I know you love x86 assembly :) ...
6 years, 6 months ago (2014-05-30 01:12:08 UTC) #2
rileya (GONE FROM CHROMIUM)
Actually publish the above-mentioned comment... https://codereview.chromium.org/308003004/diff/20001/media/base/sinc_resampler.cc File media/base/sinc_resampler.cc (right): https://codereview.chromium.org/308003004/diff/20001/media/base/sinc_resampler.cc#newcode367 media/base/sinc_resampler.cc:367: #elif defined(ARCH_CPU_ARM_FAMILY) && defined(USE_NEON) ...
6 years, 6 months ago (2014-05-30 01:12:29 UTC) #3
DaleCurtis
Per offline discussion, some ChromeOS boards are definitely setting arm_neon=1, though notably Android does not. ...
6 years, 6 months ago (2014-05-30 01:22:50 UTC) #4
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 6 months ago (2014-05-30 01:22:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/308003004/20001
6 years, 6 months ago (2014-05-30 01:25:13 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 06:06:17 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 06:26:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/10868)
6 years, 6 months ago (2014-05-30 06:26:26 UTC) #9
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 6 months ago (2014-05-30 18:05:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/308003004/40001
6 years, 6 months ago (2014-05-30 18:07:43 UTC) #11
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 6 months ago (2014-05-30 19:44:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/308003004/60001
6 years, 6 months ago (2014-05-30 19:45:57 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 00:50:55 UTC) #14
Message was sent while issue was closed.
Change committed as 273964

Powered by Google App Engine
This is Rietveld 408576698