Allow requesting Automation tree by tabId

chrome/browser/extensions/api/tabs/tabs_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
 
 #include <algorithm>
 #include <limits>
 #include <vector>
 
@@ skipping 114 matching lines @@
 // appropriate message if the tab cannot be found by id.
 bool GetTabById(int tab_id,
                 Profile* profile,
                 bool include_incognito,
                 Browser** browser,
                 TabStripModel** tab_strip,
                 content::WebContents** contents,
                 int* tab_index,
                 std::string* error_message) {
   if (ExtensionTabUtil::GetTabById(tab_id, profile, include_incognito,
-                                   browser, tab_strip, contents, tab_index))
+                                   browser, tab_strip, contents, tab_index)) {
     return true;
+  }
 
-  if (error_message)
+  if (error_message) {
     *error_message = ErrorUtils::FormatErrorMessage(
         keys::kTabNotFoundError, base::IntToString(tab_id));
+  }

[not at google - send to devlin, 2014/05/29 22:41:37]

ok :)

 
   return false;
 }
 
 // Returns true if either |boolean| is a null pointer, or if |*boolean| and
 // |value| are equal. This function is used to check if a tab's parameters match
 // those of the browser.
 bool MatchesBool(bool* boolean, bool value) {
   return !boolean || *boolean == value;
 }
@@ skipping 125 matching lines @@
       error_ = keys::kIncognitoModeIsForced;
       *is_error = true;
       return false;
     }
   } else if (incognito_availability == IncognitoModePrefs::FORCED) {
     // If incognito argument is not specified explicitly, we default to
     // incognito when forced so by policy.
     incognito = true;
   }
 
+

[not at google - send to devlin, 2014/05/29 22:41:37]

no blank line

[aboxhall, 2014/05/30 15:37:11]

Done.

   // Remove all URLs that are not allowed in an incognito session. Note that a
   // ChromeOS guest session is not considered incognito in this case.
   if (incognito && !GetProfile()->IsGuestSession()) {
     std::string first_url_erased;
     for (size_t i = 0; i < urls->size();) {
       if (chrome::IsURLAllowedInIncognito((*urls)[i], GetProfile())) {
         i++;
       } else {
         if (first_url_erased.empty())
           first_url_erased = (*urls)[i].spec();
@@ skipping 1440 matching lines @@
   execute_tab_id_ = tab_id;
   details_ = details.Pass();
   return true;
 }
 
 bool TabsInsertCSSFunction::ShouldInsertCSS() const {
   return true;
 }
 
 }  // namespace extensions