Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 307993011: QUIC - Added a histogram to count the number of current active sessions (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

QUIC - Added a histogram to count the number of current active sessions before we add a new session to the active sessions. R=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274356

Patch Set 1 #

Patch Set 2 : added Net.QuicActiveSessions to histograms.xml #

Total comments: 2

Patch Set 3 : edited description per rch's comments in PatchSet 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M net/quic/quic_stream_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
ramant (doing other things)
Hi Jim and Ryan, Added a histogram to count the #of active sessions that are ...
6 years, 6 months ago (2014-06-02 02:08:03 UTC) #1
Ryan Hamilton
Please also edit histograms.xml as part of this CL.
6 years, 6 months ago (2014-06-02 15:30:48 UTC) #2
ramant (doing other things)
Added Net.QuicActiveSessions to histograms.xml. Could the description be "Number of other live active sessions". thanks, ...
6 years, 6 months ago (2014-06-02 17:05:21 UTC) #3
Ryan Hamilton
lgtm https://codereview.chromium.org/307993011/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/307993011/diff/20001/tools/metrics/histograms/histograms.xml#newcode13512 tools/metrics/histograms/histograms.xml:13512: + The number of active QUIC sessions before ...
6 years, 6 months ago (2014-06-02 17:10:51 UTC) #4
ramant (doing other things)
https://codereview.chromium.org/307993011/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/307993011/diff/20001/tools/metrics/histograms/histograms.xml#newcode13512 tools/metrics/histograms/histograms.xml:13512: + The number of active QUIC sessions before we ...
6 years, 6 months ago (2014-06-02 17:16:28 UTC) #5
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 6 months ago (2014-06-02 17:16:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/307993011/40001
6 years, 6 months ago (2014-06-02 17:17:35 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 19:40:04 UTC) #8
ramant (doing other things)
Hi Jim, Isherman, Would appreciate if you could take a look at histograms.xml (for OWNER's ...
6 years, 6 months ago (2014-06-02 19:44:04 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 19:46:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71117)
6 years, 6 months ago (2014-06-02 19:46:42 UTC) #11
jar (doing other things)
lgtm
6 years, 6 months ago (2014-06-02 22:22:02 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 22:34:09 UTC) #13
Message was sent while issue was closed.
Change committed as 274356

Powered by Google App Engine
This is Rietveld 408576698