Issue 307993010: Add RLZ build file for GN build, fix Windows build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 307993010: Add RLZ build file for GN build, fix Windows build. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina, cbentzel+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add RLZ build file for GN build, fix Windows build. Some ICU settings were incorrect in the non-component build that caused functions not to get linked properly. We set the wrong exception handling flag in non-component mode. Add rlz to the GN build. Some NSS files were missing. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274298

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -10 lines)			Patch
M	BUILD.gn	View	1 2 3 4 5	1 chunk	+7 lines, -0 lines	0 comments	Download
M	build/config/compiler/BUILD.gn	View		1 chunk	+6 lines, -2 lines	0 comments	Download
A	rlz/BUILD.gn	View	1 2	1 chunk	+136 lines, -0 lines	0 comments	Download
M	tools/gn/secondary/third_party/icu/BUILD.gn	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	tools/gn/secondary/third_party/nss/BUILD.gn	View	1 2	3 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #6 manually as r274298.

Expand Messages | Collapse Messages