Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 307993007: ash: Convert ash_resources to a normal GYP file. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang, James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

ash: Convert ash_resources to a normal GYP file. It seems to be much more common to have this kind of resources file as a normal GYP file rather than an *include* GYP file. $ git ls-files | grep resources.gyp$ | grep -v ash_resources | wc -l 9 vs $ git ls-files | grep resources.gypi$ | grep -v ash_resources | wc -l 3 BUG=None TEST=None R=jamescook@chromium.org NOTRY=true TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -41 lines) Patch
M ash/ash.gyp View 6 chunks +8 lines, -11 lines 0 comments Download
A + ash/ash_resources.gyp View 0 chunks +-1 lines, --1 lines 0 comments Download
D ash/ash_resources.gypi View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
6 years, 6 months ago (2014-05-30 22:47:15 UTC) #1
James Cook
LGTM
6 years, 6 months ago (2014-05-30 23:37:13 UTC) #2
tfarina
TBRing Lei for trivial chrome/ changes.
6 years, 6 months ago (2014-06-01 18:55:03 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-01 18:55:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/307993007/1
6 years, 6 months ago (2014-06-01 18:55:53 UTC) #5
commit-bot: I haz the power
Change committed as 274130
6 years, 6 months ago (2014-06-01 18:56:32 UTC) #6
Lei Zhang
6 years, 6 months ago (2014-06-02 22:02:50 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698