Enable the ManagedBookmarks policy on all platforms.

Enable the ManagedBookmarks policy on all platforms.

This CL makes a couple more changes to accomodate for the implementation
of this policy:

- moved the kManagedBookmarks pref into the bookmarks component, so that
it can be referred to from there;

- moved the strings for the managed bookmarks folder name for the same
reasons;

- updated the policy schema to support child bookmarks;

- updated the ManagedBookmarksPolicyHandler to use the schema validation
code, and added a new unit test for that.

TBR=nyquist@chromium.org
BUG=49598
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274124

[Joao da Silva, 2014-05-30 12:53:18]

PTAL:

@pastarmovj: policy changes

@nyquist: android changes (more to come in subsequent CLs!)

@sky: bookmarks changes

Thanks!

[sky, 2014-05-30 13:12:53]

LGTM

https://codereview.chromium.org/307993005/diff/1/components/bookmarks/common/...
File components/bookmarks/common/bookmark_pref_names.h (right):

https://codereview.chromium.org/307993005/diff/1/components/bookmarks/common/...
components/bookmarks/common/bookmark_pref_names.h:16: extern const char
kManagedBookmarks[];
nit: please alphabetize these.

[pastarmovj, 2014-05-30 14:07:13]

lgtm with two nits.

https://codereview.chromium.org/307993005/diff/1/chrome/browser/policy/manage...
File chrome/browser/policy/managed_bookmarks_policy_handler.cc (right):

https://codereview.chromium.org/307993005/diff/1/chrome/browser/policy/manage...
chrome/browser/policy/managed_bookmarks_policy_handler.cc:50:
base::DictionaryValue* dict = NULL;
I think having a short one liners about the logic these checks do to delete
entries in the list and dictionary will help maintaining this code. The checks
are rather trivial and yet they are plenty.

https://codereview.chromium.org/307993005/diff/1/chrome/browser/policy/manage...
File chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc (right):

https://codereview.chromium.org/307993005/diff/1/chrome/browser/policy/manage...
chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc:104:
TEST_F(ManagedBookmarksPolicyHandlerTest, WrongType) {
Please change this to WrongPolicyType

[Joao da Silva, 2014-05-30 20:54:34]

https://codereview.chromium.org/307993005/diff/1/chrome/browser/policy/manage...
File chrome/browser/policy/managed_bookmarks_policy_handler.cc (right):

https://codereview.chromium.org/307993005/diff/1/chrome/browser/policy/manage...
chrome/browser/policy/managed_bookmarks_policy_handler.cc:50:
base::DictionaryValue* dict = NULL;
On 2014/05/30 14:07:13, pastarmovj wrote:
> I think having a short one liners about the logic these checks do to delete
> entries in the list and dictionary will help maintaining this code. The checks
> are rather trivial and yet they are plenty.

Done.

https://codereview.chromium.org/307993005/diff/1/chrome/browser/policy/manage...
File chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc (right):

https://codereview.chromium.org/307993005/diff/1/chrome/browser/policy/manage...
chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc:104:
TEST_F(ManagedBookmarksPolicyHandlerTest, WrongType) {
On 2014/05/30 14:07:13, pastarmovj wrote:
> Please change this to WrongPolicyType

Done.

https://codereview.chromium.org/307993005/diff/1/components/bookmarks/common/...
File components/bookmarks/common/bookmark_pref_names.h (right):

https://codereview.chromium.org/307993005/diff/1/components/bookmarks/common/...
components/bookmarks/common/bookmark_pref_names.h:16: extern const char
kManagedBookmarks[];
On 2014/05/30 13:12:53, sky wrote:
> nit: please alphabetize these.

Done.

[Joao da Silva, 2014-06-01 12:50:21]

The CQ bit was checked by joaodasilva@chromium.org

[commit-bot: I haz the power, 2014-06-01 12:50:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/307993005/70001

[commit-bot: I haz the power, 2014-06-01 17:16:40]

Change committed as 274124