Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2399)

Issue 307983002: Use new ExtensionFunction::Error(..) error syntax in automation internal API. (Closed)

Created:
6 years, 6 months ago by not at google - send to devlin
Modified:
6 years, 6 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Use new ExtensionFunction::Error(..) error syntax in automation internal API. R=aboxhall@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/extensions/api/automation_internal/automation_internal_api.cc View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
6 years, 6 months ago (2014-05-29 15:34:43 UTC) #1
aboxhall
lgtm
6 years, 6 months ago (2014-05-29 22:31:47 UTC) #2
aboxhall
The CQ bit was checked by aboxhall@chromium.org
6 years, 6 months ago (2014-05-29 22:31:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/307983002/1
6 years, 6 months ago (2014-05-29 22:35:39 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 07:20:50 UTC) #5
Message was sent while issue was closed.
Change committed as 273751

Powered by Google App Engine
This is Rietveld 408576698