Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 307973004: Allow creating SharedBitmaps backed by new[] (Closed)

Created:
6 years, 6 months ago by jbauman
Modified:
6 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam
Visibility:
Public.

Description

Allow creating SharedBitmaps backed by new[] Bitmaps allocated in the browser process may have to be shared between compositors (for surfaces) but not between processes, so they should be backed by new[] and use the SharedBitmap mechanism. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -3 lines) Patch
M cc/resources/shared_bitmap.h View 3 chunks +6 lines, -1 line 0 comments Download
M cc/resources/shared_bitmap.cc View 1 chunk +12 lines, -1 line 0 comments Download
M content/common/host_shared_bitmap_manager.cc View 3 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
jbauman
6 years, 6 months ago (2014-05-29 18:32:34 UTC) #1
piman
lgtm
6 years, 6 months ago (2014-05-29 21:51:34 UTC) #2
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 6 months ago (2014-05-29 21:52:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/307973004/1
6 years, 6 months ago (2014-05-29 21:55:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 01:47:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 04:39:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/21422)
6 years, 6 months ago (2014-05-30 04:39:42 UTC) #7
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 6 months ago (2014-05-30 05:14:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/307973004/1
6 years, 6 months ago (2014-05-30 05:19:27 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 07:02:29 UTC) #10
Message was sent while issue was closed.
Change committed as 273743

Powered by Google App Engine
This is Rietveld 408576698